From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id BA52A1FF0BC for ; Thu, 29 Oct 2026 13:09:01 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id B1A162166D; Thu, 29 Oct 2026 13:08:27 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v2 3/7] api: clone disk: downgrade failure to register unused volume to warning Date: Thu, 29 Oct 2026 13:06:54 +0100 Message-ID: <20261029120811.107814-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261029120811.107814-1-f.ebner@proxmox.com> References: <20261029120811.107814-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793275700917 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.329 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: E5KO3SSP5BKEOG4ILRLYI6BHYMPZXBDX X-Message-ID-Hash: E5KO3SSP5BKEOG4ILRLYI6BHYMPZXBDX X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When reaching the call to register the source volume as unused after clone, a running VM will already be switched over to the new disk. If an error occurs there (because all unused slots are already in use), the new disk would be removed in the error handling. Even if it is an offline clone, the failure to register the source volume as unused should not lead to aborting/reversing the whole operation. Downgrade the error to a warning. Reported-by: Elias Huhsovitz Signed-off-by: Fiona Ebner --- New in v2. src/PVE/API2/Qemu.pm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm index ebbfcb1b..9540db86 100644 --- a/src/PVE/API2/Qemu.pm +++ b/src/PVE/API2/Qemu.pm @@ -5012,8 +5012,12 @@ __PACKAGE__->register_method({ $conf->{$disk} = PVE::QemuServer::print_drive($newdrive); if (!$param->{delete}) { - my $unused_key = PVE::QemuConfig->add_unused_volume($conf, $old_volid); - print("adding source volume '$old_volid' as '$unused_key' to config\n"); + eval { + my $unused_key = PVE::QemuConfig->add_unused_volume($conf, $old_volid); + print("adding source volume '$old_volid' as '$unused_key' to config\n"); + }; + log_warn("cannot add source volume '$old_volid' as unused to config - $@") + if $@; } # convert moved disk to base if part of template -- 2.47.3