From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 424531FF0BC for ; Thu, 29 Oct 2026 13:08:29 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 2D309213DD; Thu, 29 Oct 2026 13:08:26 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v2 2/7] drive: get tpm state size: also warn if there was no size returned Date: Thu, 29 Oct 2026 13:06:53 +0100 Message-ID: <20261029120811.107814-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261029120811.107814-1-f.ebner@proxmox.com> References: <20261029120811.107814-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793275700862 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.330 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KLQX5KNDTXLP3ZNZ3FR4YSL3KUU73VL6 X-Message-ID-Hash: KLQX5KNDTXLP3ZNZ3FR4YSL3KUU73VL6 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Some storage plugin implementations of the volume_size_info() method do not fail with a hard error. In particular, the native file-based plugins use file_size_info() which returns undef upon failure. Thus, explicitly check the size. Signed-off-by: Fiona Ebner --- New in v2. src/PVE/QemuServer/Drive.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/PVE/QemuServer/Drive.pm b/src/PVE/QemuServer/Drive.pm index 0ca3d636..7b288e78 100644 --- a/src/PVE/QemuServer/Drive.pm +++ b/src/PVE/QemuServer/Drive.pm @@ -1334,7 +1334,9 @@ sub get_tpmstate_size { if !defined($storecfg); my $size = eval { PVE::Storage::volume_size_info($storecfg, $volid, 10) }; - warn "failed to get size of the tpm drive $volid: $@" if $@; + my $err = $@; + $err = "no size in result" if !$err && !$size; + warn "failed to get size of the tpm drive $volid: $err" if $err; if (!$size || $size < TPMSTATE_DISK_SIZE) { $size = TPMSTATE_DISK_SIZE; -- 2.47.3