From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 22EB11FF0BC for ; Thu, 29 Oct 2026 13:08:54 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 62FD32164E; Thu, 29 Oct 2026 13:08:27 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH-SERIES qemu-server v2 0/7] fix #8209: clone disk: do not ignore failure to query size of target Date: Thu, 29 Oct 2026 13:06:51 +0100 Message-ID: <20261029120811.107814-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793275700711 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.328 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5QVDIFJS3VGP2VCOKY5CK2DL5AHTXONJ X-Message-ID-Hash: 5QVDIFJS3VGP2VCOKY5CK2DL5AHTXONJ X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Changes in v2: * Rebase on current master. * Bump timeout also for querying size of source volume. * Add patch to fix issue when adding unused volume fails. * Improve log output. Since commit 3bae384f ("clone disk: avoid errors after disk was moved by QEMU"), failure to query the target volume's size after clone is ignored. It's sensible not to fail hard at this stage, because in case of live mirror for the same VM with 'complete' completion mode, the drive was already switched. Also, the error might be a harmless timeout. Still, as reported in bug #8209, there could be an actual issue, so log a warning and communicate a failure to the caller, so it can avoid destructive action. qemu-server: Fiona Ebner (7): block job: monitor: document that job-complete is not used if source differs from target drive: get tpm state size: also warn if there was no size returned api: clone disk: downgrade failure to register unused volume to warning fix #8209: clone disk: do not ignore failure to query size of target clone disk: abort early when failing to query size of source disk drive: get tpm state size: add timeout parameter clone disk: bump timeout for querying volume sizes to 1 minute src/PVE/API2/Qemu.pm | 31 ++++++++++++++++++++++--------- src/PVE/QemuServer.pm | 24 ++++++++++++++++++++---- src/PVE/QemuServer/BlockJob.pm | 1 + src/PVE/QemuServer/Drive.pm | 13 +++++++++---- 4 files changed, 52 insertions(+), 17 deletions(-) Summary over all repositories: 4 files changed, 52 insertions(+), 17 deletions(-) -- Generated by git-murpp 0.5.0