From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 8A7761FF0BC for ; Thu, 29 Oct 2026 04:54:30 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 8086A213BC; Thu, 29 Oct 2026 04:54:26 +0100 (CET) From: Kefu Chai To: pve-devel@lists.proxmox.com Subject: [PATCH manager v2 0/1] fix #5327: ceph: osd: create: accept multiple Ceph networks Date: Thu, 29 Oct 2026 11:54:17 +0800 Message-ID: <20261029035418.3324517-1-k.chai@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793246062145 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.271 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: L3TO6QTMVX5S2HCYZLECLVSCBYGCAVGK X-Message-ID-Hash: L3TO6QTMVX5S2HCYZLECLVSCBYGCAVGK X-MailFrom: k.chai@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi, this is v2 of my patch [1] for creating OSDs on clusters with more than one Ceph network. Sorry, when I sent v1 I missed that Max had already posted a fix for the same bug back in July [2], so now there are two patches for #5327 on the list. I only noticed while looking at #8087, which reports the same problem. Both patches split the network list and accept the node if any of the subnets has a local address, but they split it differently. Ceph takes commas and spaces as separators, and the config in #5327 uses a space: cluster_network = 192.168.254.10/24 192.168.0.100/24 If I read it right, Max's patch only splits on commas, so this value would still go to `ip address show to` as one string and fail. This patch uses split_list(), like monitor creation does, so both work. With this patch, an empty "cluster_network =" also falls back to public_network, like Ceph does, instead of skipping the check. And the error message names the option it checked, so it doesn't say "cluster network" when the value came from public_network. Max's patch also warns about a subnet it can't look up and moves on, which looks intended. Mine fails there, unless an earlier subnet already matched. Ceph won't start with a network it can't parse anyway, so I think failing is fine, but I'm happy to switch to a warning if that's preferred. And if Max's version is the one to keep, I can drop this and send the space handling on top of his. I tested it on a three-node lab cluster with comma- and space-separated lists, a list of /32s like in #8087, a list without any local subnet, and an empty cluster_network. Changes since v1: - add "fix #5327" and mention #8087 - mention in the commit message that spaces work as separators too - rebase onto current master [1] https://lore.proxmox.com/pve-devel/20261009031555.3414265-1-k.chai@proxmox.com/ [2] https://lore.proxmox.com/pve-devel/20260728113729.2136104-1-m.carrara@proxmox.com/ Kefu Chai (1): fix #5327: ceph: osd: create: accept multiple Ceph networks PVE/API2/Ceph/OSD.pm | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) -- 2.47.3