From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id B9E0A1FF0B0 for ; Tue, 27 Oct 2026 11:49:57 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 66CB32166F; Tue, 27 Oct 2026 11:49:55 +0100 (CET) From: Elias Huhsovitz To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox-perl-rs 1/3] makefile: use TARGET_DIR variable for install target Date: Tue, 27 Oct 2026 11:49:33 +0100 Message-ID: <20261027104935.49190-2-e.huhsovitz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261027104935.49190-1-e.huhsovitz@proxmox.com> References: <20261027104935.49190-1-e.huhsovitz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793098191732 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.487 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: Z74PJQFMS5YEK456QWTRFGGTVL45Y2TZ X-Message-ID-Hash: Z74PJQFMS5YEK456QWTRFGGTVL45Y2TZ X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Elias Huhsovitz X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Currently calling 'make all' and 'make install' fails, because make builds a debug binary inside 'target/debug'. 'make install' is hardcoded to always install the release binary inside of 'target/release/'. Replace the hardcoded install path with the TARGET_DIR variable, so that 'make install' installs the binary compiled with 'make all'. Release builds can still be compiled and installed by using 'BUILD_MODE=release make all' and 'BUILD_MODE=release make install' Signed-off-by: Elias Huhsovitz --- pmg-rs/Makefile | 4 ++-- pve-rs/Makefile | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pmg-rs/Makefile b/pmg-rs/Makefile index a873143..d5063f9 100644 --- a/pmg-rs/Makefile +++ b/pmg-rs/Makefile @@ -71,9 +71,9 @@ Proxmox/Lib/PMG.pm $(PERLMOD_PACKAGE_FILES) &: Fixup.pm $(PERLMOD_GENPACKAGE) $(PERLMOD_PACKAGES) .PHONY: install -install: target/release/libpmg_rs.so Proxmox/Lib/PMG.pm $(PERLMOD_PACKAGE_FILES) +install: target/$(TARGET_DIR)/libpmg_rs.so Proxmox/Lib/PMG.pm $(PERLMOD_PACKAGE_FILES) install -d -m755 $(DESTDIR)$(PERL_INSTALLVENDORARCH)/auto - install -m644 target/release/libpmg_rs.so $(DESTDIR)$(PERL_INSTALLVENDORARCH)/auto/libpmg_rs.so + install -m644 target/$(TARGET_DIR)/libpmg_rs.so $(DESTDIR)$(PERL_INSTALLVENDORARCH)/auto/libpmg_rs.so install -d -m755 $(DESTDIR)$(PERL_INSTALLVENDORLIB) install -d -m755 $(DESTDIR)$(PERL_INSTALLVENDORLIB)/Proxmox/Lib install -m644 Proxmox/Lib/PMG.pm $(DESTDIR)$(PERL_INSTALLVENDORLIB)/Proxmox/Lib/PMG.pm diff --git a/pve-rs/Makefile b/pve-rs/Makefile index bb1cd2d..1e3e792 100644 --- a/pve-rs/Makefile +++ b/pve-rs/Makefile @@ -89,9 +89,9 @@ check: all $(MAKE) -C test test .PHONY: install -install: target/release/libpve_rs.so Proxmox/Lib/PVE.pm $(PERLMOD_PACKAGE_FILES) +install: target/$(TARGET_DIR)/libpve_rs.so Proxmox/Lib/PVE.pm $(PERLMOD_PACKAGE_FILES) install -d -m755 $(DESTDIR)$(PERL_INSTALLVENDORARCH)/auto - install -m644 target/release/libpve_rs.so $(DESTDIR)$(PERL_INSTALLVENDORARCH)/auto/libpve_rs.so + install -m644 target/$(TARGET_DIR)/libpve_rs.so $(DESTDIR)$(PERL_INSTALLVENDORARCH)/auto/libpve_rs.so install -d -m755 $(DESTDIR)$(PERL_INSTALLVENDORLIB) install -d -m755 $(DESTDIR)$(PERL_INSTALLVENDORLIB)/Proxmox/Lib install -m644 Proxmox/Lib/PVE.pm $(DESTDIR)$(PERL_INSTALLVENDORLIB)/Proxmox/Lib/PVE.pm -- 2.47.3