From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id C05381FF0AE for ; Tue, 27 Oct 2026 09:55:43 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id F3E4D211F7; Tue, 27 Oct 2026 09:55:42 +0100 (CET) From: Hannes Laimer To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox-ve-rs v3 04/45] ve-config: firewall: add a constructor for sctp matches Date: Tue, 27 Oct 2026 09:54:46 +0100 Message-ID: <20261027085527.702738-5-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261027085527.702738-1-h.laimer@proxmox.com> References: <20261027085527.702738-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793091337565 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.339 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MZOZ7G2M3HLUT5AI5OUKQZRIZ4C7HNPP X-Message-ID-Hash: MZOZ7G2M3HLUT5AI5OUKQZRIZ4C7HNPP X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The tcp and udp matches can already be built from source and destination ports, while an sctp match with ports can only be built by parsing a rule. Add the missing constructor so a match on any protocol that carries ports can be built without parsing. Signed-off-by: Hannes Laimer --- proxmox-ve-config/src/firewall/types/rule_match.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/proxmox-ve-config/src/firewall/types/rule_match.rs b/proxmox-ve-config/src/firewall/types/rule_match.rs index 8e142f74e4e6..8e9c0c69efe8 100644 --- a/proxmox-ve-config/src/firewall/types/rule_match.rs +++ b/proxmox-ve-config/src/firewall/types/rule_match.rs @@ -437,6 +437,10 @@ pub struct Sctp { } impl Sctp { + pub fn new(ports: Ports) -> Self { + Self { ports } + } + fn from_options(options: &RuleOptions) -> Result { Ok(Self { ports: Ports::from_options(options)?, -- 2.47.3