From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 3C1B31FF0E3 for ; Tue, 27 Oct 2026 10:01:55 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 13FB021ACE; Tue, 27 Oct 2026 09:57:10 +0100 (CET) From: Hannes Laimer To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v3 40/45] ui: sdn: microseg: add fragments option to the rule form Date: Tue, 27 Oct 2026 09:55:22 +0100 Message-ID: <20261027085527.702738-41-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261027085527.702738-1-h.laimer@proxmox.com> References: <20261027085527.702738-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793091377118 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.349 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LZEWXBNGBD2K5P4K3HWFPPFFILVCDPKW X-Message-ID-Hash: LZEWXBNGBD2K5P4K3HWFPPFFILVCDPKW X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Hannes Laimer --- www/manager6/sdn/microseg/RuleEdit.js | 26 +++++++++++++++++++++++--- www/manager6/sdn/microseg/RuleView.js | 4 ++++ 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/www/manager6/sdn/microseg/RuleEdit.js b/www/manager6/sdn/microseg/RuleEdit.js index 3ee9c3b36e46..95620050fad4 100644 --- a/www/manager6/sdn/microseg/RuleEdit.js +++ b/www/manager6/sdn/microseg/RuleEdit.js @@ -69,20 +69,24 @@ Ext.define('PVE.sdn.microseg.RuleInputPanel', { let updateNarrowing = () => { let macro = me.down('field[name=macro]'); let proto = me.down('field[name=proto]'); + let fragments = me.isCreate && !!me.down('field[name=fragments]').getValue(); + if (me.isCreate) { + setNarrowing(macro, !fragments, fragments); + } let byMacro = !Ext.isEmpty(macro.getValue()); if (me.isCreate) { setNarrowing(proto, !byMacro, byMacro); } - let editable = me.isCreate && !byMacro; + let editable = me.isCreate && !fragments && !byMacro; let protocol = proto.getValue(); let icmpv4 = protocol === 'icmp'; let icmpv6 = protocol === 'icmpv6' || protocol === 'ipv6-icmp'; let v4 = me.down('#microsegIcmpv4Type'); let v6 = me.down('#microsegIcmpv6Type'); v4.setHidden(!icmpv4); - setNarrowing(v4, icmpv4 && editable); + setNarrowing(v4, icmpv4 && editable, fragments); v6.setHidden(!icmpv6); - setNarrowing(v6, icmpv6 && editable); + setNarrowing(v6, icmpv6 && editable, fragments); let ports = !icmpv4 && !icmpv6; for (const name of ['sport', 'dport']) { let field = me.down(`field[name=${name}]`); @@ -240,6 +244,22 @@ Ext.define('PVE.sdn.microseg.RuleInputPanel', { [0, gettext('Deny')], ], }, + { + xtype: 'proxmoxcheckbox', + name: 'fragments', + fieldLabel: gettext('Fragments Only'), + uncheckedValue: null, + disabled: !me.isCreate, + autoEl: { + tag: 'div', + 'data-qtip': gettext( + 'Match the IP fragments after the first. They carry no ports and no ICMP type.', + ), + }, + listeners: { + change: updateNarrowing, + }, + }, ]; me.columnB = [ diff --git a/www/manager6/sdn/microseg/RuleView.js b/www/manager6/sdn/microseg/RuleView.js index 58d81221402c..95c08343e725 100644 --- a/www/manager6/sdn/microseg/RuleView.js +++ b/www/manager6/sdn/microseg/RuleView.js @@ -169,6 +169,9 @@ Ext.define( return data.macro; } let proto = data.proto; + if (data.fragments) { + return proto ? `${proto} ${gettext('fragments')}` : gettext('fragments'); + } if (!proto) { return ''; } @@ -296,6 +299,7 @@ Ext.define( 'dport', 'icmp-type', 'macro', + 'fragments', 'direction', 'rank', 'specificity', -- 2.47.3