From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id AF4D41FF09B for ; Mon, 26 Oct 2026 23:05:10 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 213F6215F8; Mon, 26 Oct 2026 23:04:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=datenzelt.de; s=MBO0001; t=1793052277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yeGPkoz1Y2VcgEqlu73qfYMYfKH1ZkqjOnFv4QjnH1Q=; b=Kzd4OLdzlxy0+yS7dGOR6ka14KMuKp+NWM9PJ2DDimCZjciFv8YwIY5Duo4OJeK9fq8ERk Upok7Fzu8WxTMN/hGtXZUmgHnRkYfVFcS1+IWa/GV99yPUDdx/DOLkCRZOjdmYyDlva3/p wLVR0dZakzrFVbvR+3Tr98lsYqKtQoxB4fq8WqaYgfeerxbMKsuykMl2AhAouFhbUdhLxf OodHoLM1BxXyvrsfcg9vN7R5+FvquFe+mafaoMFA28/WiFWrsTDeML3pePdmnRCFBnblH0 te/AhEiGEq4RBx4p9MTKYMN3BbCVNbLVqPQsqLSVqmyYaz2FD0CSjwdK+8bViA== Authentication-Results: outgoing_mbo_mout; dkim=none; spf=pass (outgoing_mbo_mout: domain of timo.meschkat@datenzelt.de designates 2001:67c:2050:b231:465::1 as permitted sender) smtp.mailfrom=timo.meschkat@datenzelt.de From: Timo Meschkat To: pve-devel@lists.proxmox.com Subject: [RFC PATCH manager 3/4] ui: disk storage selector: allow selecting the size unit Date: Mon, 26 Oct 2026 23:04:22 +0100 Message-ID: <20261026220423.127776-7-timo.meschkat@datenzelt.de> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261026220423.127776-1-timo.meschkat@datenzelt.de> References: <20261026220423.127776-1-timo.meschkat@datenzelt.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4jD72Y470szKmcv X-SPAM-LEVEL: Spam detection results: 0 AWL 0.175 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GRAKJ6AAIXC5DESF3AILM2O7XFQUFECT X-Message-ID-Hash: GRAKJ6AAIXC5DESF3AILM2O7XFQUFECT X-MailFrom: timo.meschkat@datenzelt.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The size of new VM disks and container volumes could only be entered in GiB so far, so small disks needed fractions and large ones a conversion. GiB stays the default and is still what gets sent to the API. The minimum is now 1 MiB instead of 0.001 GiB, so that it is a round value in the smallest selectable unit. Signed-off-by: Timo Meschkat --- www/manager6/form/DiskStorageSelector.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/www/manager6/form/DiskStorageSelector.js b/www/manager6/form/DiskStorageSelector.js index 696f9033..df94c938 100644 --- a/www/manager6/form/DiskStorageSelector.js +++ b/www/manager6/form/DiskStorageSelector.js @@ -157,13 +157,17 @@ Ext.define('PVE.form.DiskStorageSelector', { hidden: true, }, { - xtype: 'numberfield', + xtype: 'pmxSizeUnitField', itemId: 'disksize', name: 'disksize', - fieldLabel: `${gettext('Disk size')} (${gettext('GiB')})`, + fieldLabel: gettext('Disk size'), + fieldDescription: gettext('Capacity of the disk'), hidden: me.hideSize, disabled: me.hideSize, - minValue: 0.001, + backendUnit: 'GiB', + unit: 'GiB', + allowFractionalValue: true, + minValue: 1 / 1024, maxValue: 128 * 1024, decimalPrecision: 3, value: me.defaultSize, -- 2.47.3