From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id CF37D1FF0BC for ; Thu, 15 Oct 2026 17:42:56 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 950D521491; Thu, 15 Oct 2026 17:42:53 +0200 (CEST) From: Lukas Sichert To: pve-devel@lists.proxmox.com Subject: [PATCH network 1/3] api: zones: enable strict and warnings Date: Thu, 15 Oct 2026 17:42:39 +0200 Message-ID: <20261015154243.304235-2-l.sichert@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261015154243.304235-1-l.sichert@proxmox.com> References: <20261015154243.304235-1-l.sichert@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792078970472 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.653 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 24YRZYSWN5Q5JZ56FTRZNSLLBXZZCQ3X X-Message-ID-Hash: 24YRZYSWN5Q5JZ56FTRZNSLLBXZZCQ3X X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Lukas Sichert X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The Proxmox style guide requires every perl module to enable both pragmas, but this one did not. Without them, typos in variable names and uses of undefined values in this module go unnoticed instead of being reported. Signed-off-by: Lukas Sichert --- src/PVE/API2/Network/SDN/Nodes/Zones.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/API2/Network/SDN/Nodes/Zones.pm b/src/PVE/API2/Network/SDN/Nodes/Zones.pm index b92be6a..db94b8f 100644 --- a/src/PVE/API2/Network/SDN/Nodes/Zones.pm +++ b/src/PVE/API2/Network/SDN/Nodes/Zones.pm @@ -1,5 +1,8 @@ package PVE::API2::Network::SDN::Nodes::Zones; +use strict; +use warnings; + use PVE::API2::Network::SDN::Nodes::Zone; use PVE::INotify; use PVE::JSONSchema qw(get_standard_option); -- 2.47.3