From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 6131A1FF0BC for ; Thu, 15 Oct 2026 14:51:35 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id EE31421622; Thu, 15 Oct 2026 14:51:21 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager v4 06/27] next state stopped: align logging for motion command with next_state_started() Date: Thu, 15 Oct 2026 14:50:40 +0200 Message-ID: <20261015125112.174954-7-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261015125112.174954-1-f.ebner@proxmox.com> References: <20261015125112.174954-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792068676470 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.421 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: AOVHKGMEKBDJADCW3I76ZUE4UFL5FHYL X-Message-ID-Hash: AOVHKGMEKBDJADCW3I76ZUE4UFL5FHYL X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: In preparation to factor out the code for handling a motion command in next_state_{started,stopped}() into a common helper. Signed-off-by: Fiona Ebner --- Changes in v4: * Split into its own patch. src/PVE/HA/Manager.pm | 1 + src/test/test-relocate-to-inactive-node/log.expect | 1 + src/test/test-service-stopped3/log.expect | 1 + 3 files changed, 3 insertions(+) diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm index b5da4b7..dfcdca2 100644 --- a/src/PVE/HA/Manager.pm +++ b/src/PVE/HA/Manager.pm @@ -1319,6 +1319,7 @@ sub next_state_stopped { my $target = shift @{ $sd->{cmd} }; my $logprefix = "ignore service '$sid' $cmd request"; if (check_resource_motion_valid($self, $target, $sd, $logprefix)) { + $haenv->log('info', "$cmd service '$sid' to node '$target'"); &$change_service_state($self, $sid, $cmd, node => $sd->{node}, target => $target); return; } diff --git a/src/test/test-relocate-to-inactive-node/log.expect b/src/test/test-relocate-to-inactive-node/log.expect index 266fb48..8c9d892 100644 --- a/src/test/test-relocate-to-inactive-node/log.expect +++ b/src/test/test-relocate-to-inactive-node/log.expect @@ -21,6 +21,7 @@ info 25 node3/lrm: status change wait_for_agent_lock => active info 40 node1/crm: service 'vm:103': state changed from 'request_stop' to 'stopped' info 120 cmdlist: execute service vm:103 relocate node2 info 120 node1/crm: got crm command: relocate vm:103 node2 +info 120 node1/crm: relocate service 'vm:103' to node 'node2' info 120 node1/crm: service 'vm:103': state changed from 'stopped' to 'relocate' (node = node3, target = node2) info 123 node2/lrm: got lock 'ha_agent_node2_lock' info 123 node2/lrm: status change wait_for_agent_lock => active diff --git a/src/test/test-service-stopped3/log.expect b/src/test/test-service-stopped3/log.expect index e08b54c..d4737a7 100644 --- a/src/test/test-service-stopped3/log.expect +++ b/src/test/test-service-stopped3/log.expect @@ -21,6 +21,7 @@ info 25 node3/lrm: status change wait_for_agent_lock => active info 40 node1/crm: service 'fa:1501': state changed from 'request_stop' to 'stopped' info 120 cmdlist: execute service fa:1501 migrate node2 info 120 node1/crm: got crm command: migrate fa:1501 node2 +info 120 node1/crm: migrate service 'fa:1501' to node 'node2' info 120 node1/crm: service 'fa:1501': state changed from 'stopped' to 'migrate' (node = node3, target = node2) info 123 node2/lrm: got lock 'ha_agent_node2_lock' info 123 node2/lrm: status change wait_for_agent_lock => active -- 2.47.3