From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id BDD9E1FF0B2 for ; Fri, 09 Oct 2026 02:44:03 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id EB7832144E; Fri, 09 Oct 2026 02:44:01 +0200 (CEST) From: Kefu Chai To: pve-devel@lists.proxmox.com Subject: [PATCH manager] fix #8098: ui: ceph: osd: sort OSDs naturally by name Date: Fri, 9 Oct 2026 08:43:53 +0800 Message-ID: <20261009004353.3324350-1-k.chai@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791506636570 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.405 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VUCZC4ZUPTWWPBAUE2CSYZDIQ5VMQ5JM X-Message-ID-Hash: VUCZC4ZUPTWWPBAUE2CSYZDIQ5VMQ5JM X-MailFrom: k.chai@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Sorting the OSD tree by its Name column compared plain strings, so osd.10 came before osd.8. The tree saves its sort state, so the wrong order also survived reloads. Compare names with localeCompare's numeric option, as storage/ContentView.js already does. OSDs now sort by ID, and hosts like pve2 and pve10 sort by number as well. Signed-off-by: Kefu Chai --- www/manager6/ceph/OSD.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js index e7e91eba..4c2face6 100644 --- a/www/manager6/ceph/OSD.js +++ b/www/manager6/ceph/OSD.js @@ -1202,6 +1202,10 @@ Ext.define('PVE.node.CephOsdTree', { text: 'Name', dataIndex: 'name', width: 150, + sorter: { + sorterFn: (a, b) => + a.data.name.localeCompare(b.data.name, undefined, { numeric: true }), + }, }, { text: 'Type', -- 2.47.3