From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 0B3991FF0AB for ; Wed, 07 Oct 2026 10:37:52 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 197EC214DB; Wed, 07 Oct 2026 10:37:42 +0200 (CEST) From: Elias Huhsovitz To: pve-devel@lists.proxmox.com Subject: [PATCH manager 1/2] fix #8093: pvestatd: remove cleanup of stale lxc consoles Date: Wed, 7 Oct 2026 10:37:25 +0200 Message-ID: <20261007083726.26067-2-e.huhsovitz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261007083726.26067-1-e.huhsovitz@proxmox.com> References: <20261007083726.26067-1-e.huhsovitz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791362257376 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.550 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 72AVMD7YAJJOYCYD6CCZEHLBJ73HZACA X-Message-ID-Hash: 72AVMD7YAJJOYCYD6CCZEHLBJ73HZACA X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Elias Huhsovitz X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Responsibility is moved to pve-container. Signed-off-by: Elias Huhsovitz --- PVE/Service/pvestatd.pm | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm index 34f9da71..cec66e00 100755 --- a/PVE/Service/pvestatd.pm +++ b/PVE/Service/pvestatd.pm @@ -444,20 +444,6 @@ sub update_qemu_status { PVE::PullMetric::update($pull_txn, 'qemu', $vmstatus, $ctime); } -sub remove_stale_lxc_consoles { - - my $vmstatus = PVE::LXC::vmstatus(); - my $pidhash = PVE::LXC::find_lxc_console_pids(); - - foreach my $vmid (keys %$pidhash) { - next if defined($vmstatus->{$vmid}); - syslog('info', "remove stale lxc-console for CT $vmid"); - foreach my $pid (@{ $pidhash->{$vmid} }) { - kill(9, $pid); - } - } -} - my $rebalance_error_count = {}; my $NO_REBALANCE; @@ -848,10 +834,6 @@ sub update_status { $err = $@; syslog('err', "storage status update error: $err") if $err; - eval { remove_stale_lxc_consoles(); }; - $err = $@; - syslog('err', "lxc console cleanup error: $err") if $err; - eval { rotate_authkeys(); }; $err = $@; syslog('err', "authkey rotation error: $err") if $err; -- 2.47.3