From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id E8F131FF09C for ; Mon, 05 Oct 2026 16:50:10 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id F3E1121880; Mon, 05 Oct 2026 16:48:42 +0200 (CEST) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pve-devel@lists.proxmox.com Subject: [PATCH manager v7 16/24] ui: guest ID selector: rename exists flag to rejected Date: Mon, 5 Oct 2026 16:47:57 +0200 Message-ID: <20261005144805.825538-17-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261005144805.825538-1-m.koeppl@proxmox.com> References: <20261005144805.825538-1-m.koeppl@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791211690093 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.194 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VGEBGTVEHLUIJ2TF7QQM5VYYDQWEA6UQ X-Message-ID-Hash: VGEBGTVEHLUIJ2TF7QQM5VYYDQWEA6UQ X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The flag is set whenever the /cluster/nextid endpoint rejects an ID, which includes failed requests, so it does not reliably tell whether a guest with that ID exists. Name it after what it actually records. Signed-off-by: Michael Köppl --- www/manager6/form/GuestIDSelector.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/www/manager6/form/GuestIDSelector.js b/www/manager6/form/GuestIDSelector.js index e440cf7ae..f3160a744 100644 --- a/www/manager6/form/GuestIDSelector.js +++ b/www/manager6/form/GuestIDSelector.js @@ -22,11 +22,11 @@ Ext.define('PVE.form.GuestIDSelector', { return true; } - if (me.validateExists === true && !me.exists) { + if (me.validateExists === true && !me.rejected) { return me.unknownID; } - if (me.validateExists === false && me.exists) { + if (me.validateExists === false && me.rejected) { return me.inUseID; } @@ -62,11 +62,11 @@ Ext.define('PVE.form.GuestIDSelector', { url: '/cluster/nextid', method: 'GET', success: function (response, opts) { - me.exists = false; + me.rejected = false; me.validate(); }, failure: function (response, opts) { - me.exists = true; + me.rejected = true; me.validate(); }, }); -- 2.47.3