From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id EFA6C1FF09C for ; Mon, 05 Oct 2026 13:03:46 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id DA13521670; Mon, 05 Oct 2026 13:03:32 +0200 (CEST) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH pve-storage 1/2] fix #7360: esxi: store password file as utf-8 Date: Mon, 5 Oct 2026 12:55:22 +0200 Message-ID: <20261005110306.2197624-2-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261005110306.2197624-1-a.bied-charreton@proxmox.com> References: <20261005110306.2197624-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791198208515 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.071 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZT6DCQ6IG3CPOY2PAQRSUNKXI54AOEXX X-Message-ID-Hash: ZT6DCQ6IG3CPOY2PAQRSUNKXI54AOEXX X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The password reaches esxi_set_credentials() as a Perl string, and file_set_contents() wrote it without encoding it. For characters in the U+0080 to U+00FF range, like 'é', this produced Latin-1 bytes. Both listvms.py and the FUSE tool decode the pasword file as UTF-8, so listing guests failed with a decode error. Force UTF-8 encoding when writing the file. Existing storages with an affected password need to have their password set again to rewrite the file. Link: https://bugzilla.proxmox.com/show_bug.cgi?id=7360 Signed-off-by: Arthur Bied-Charreton --- src/PVE/Storage/ESXiPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm index bc2e481..7defb7b 100644 --- a/src/PVE/Storage/ESXiPlugin.pm +++ b/src/PVE/Storage/ESXiPlugin.pm @@ -81,7 +81,7 @@ sub esxi_set_credentials { my $cred_file = esxi_cred_file_name($storeid); mkdir "/etc/pve/priv/storage"; - PVE::Tools::file_set_contents($cred_file, $password); + PVE::Tools::file_set_contents($cred_file, $password, 0600, 1); return $cred_file; } -- 2.47.3