From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 6ED9A1FF09C for ; Mon, 05 Oct 2026 13:03:33 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5F448215C6; Mon, 05 Oct 2026 13:03:31 +0200 (CEST) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH pve-storage 0/2] fix #7360: esxi: write password file as Date: Mon, 5 Oct 2026 12:55:21 +0200 Message-ID: <20261005110306.2197624-1-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791198208460 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.083 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2KONB7ZHXZ5LLXUZZAY2VAXACDZSGHYP X-Message-ID-Hash: 2KONB7ZHXZ5LLXUZZAY2VAXACDZSGHYP X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The first commit fixes the original issue, where at creation time, the password file would not be saved as UTF-8. This led to decoding errors when listing VMs (and presumably in the FUSE tool, although I did not specifically test that path). The second commit additionally rewrites non-UTF-8-encoded password files as UTF-8 to catch pre-existing broken password files. More details in the messages. Arthur Bied-Charreton (2): fix #7360: esxi: store password file as utf-8 esxi: rewrite non-UTF-8 password files src/PVE/Storage/ESXiPlugin.pm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) -- 2.47.3