From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 69F541FF0AD for ; Sun, 04 Oct 2026 13:58:33 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 130E721681; Sun, 04 Oct 2026 13:58:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dualfroz.com; s=dkim; t=1791115094; h=from:subject:date:message-id:to:mime-version: content-transfer-encoding:in-reply-to:references; bh=vjjNJrFU6xpO4z0aMeHLKv4Kz8e1rHv/YGQcwt/VquE=; b=hxZ5Azqp03aColyMfxzGmh3XOYbfeh4i4bY8vN1ig3oBzcMuDQ0bayBES2k+K+Kg6RsrVy XprooapnEsyERvOCUlJTK/6b5l05lSOUvgi4cvdcWILEngLhN4KHTA4XETY8CqgHOw1IAc eCg3ccizl4aKLHCo/X4mpMJ9UhPVQMOx19wN13sNEsQPTX+1i9nbVthWmIvZWdsvBpULwl SHoaDU5hXVX/fsMqbIbOJ8LEBIxUL/KsdfLn1QMUeX6WfnI8MA4+AQjus7IpM5WCR4z3cr 6tr2L8pFBNDGFMwREja+C2/Y1yJsL8R1+G6QSaOB0FcTzDCmc5j3T+ruUXe7Ig== From: Michal Fox To: pve-devel@lists.proxmox.com Subject: [PATCH widget-toolkit 2/2] acme: domain edit: allow setting the alias of DNS domains Date: Sun, 4 Oct 2026 11:58:09 +0000 Message-ID: <20261004115809.7-3-me@dualfroz.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261004115809.7-1-me@dualfroz.com> References: <20261004115809.7-1-me@dualfroz.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.218 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YNQH6IOSIFTKJMSEX6QTFCPRBS6VG2J5 X-Message-ID-Hash: YNQH6IOSIFTKJMSEX6QTFCPRBS6VG2J5 X-MailFrom: me@dualfroz.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Domains validated with the DNS challenge can have an alias, so that the challenge record is created on another domain, which the '_acme-challenge' record of the domain points to with a CNAME. But the alias could only be set on the CLI, as the edit window only kept an existing one in a hidden field. Show it as a text field for domains with the DNS challenge type, like the plugin. As a side effect, an existing alias is not kept anymore when switching a domain to the HTTP challenge type with separate domain entries, like it is done in Proxmox Mail Gateway, where it has no meaning. Signed-off-by: Michal Fox --- Tested in the browser the same way as the PVE window, both with the 'domains' list (PBS) and with separate domain entries and usage (PMG). src/window/ACMEDomains.js | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/src/window/ACMEDomains.js b/src/window/ACMEDomains.js index a2d2f83..029d427 100644 --- a/src/window/ACMEDomains.js +++ b/src/window/ACMEDomains.js @@ -142,16 +142,14 @@ Ext.define('Proxmox.window.ACMEDomainEdit', { change: function (cb, value) { let me = this; let view = me.up('pmxACMEDomainEdit'); - let pluginField = view.down('field[name=plugin]'); - pluginField.setDisabled(value !== 'dns'); - pluginField.setHidden(value !== 'dns'); + for (const name of ['plugin', 'alias']) { + let field = view.down(`field[name=${name}]`); + field.setDisabled(value !== 'dns'); + field.setHidden(value !== 'dns'); + } }, }, }, - { - xtype: 'hidden', - name: 'alias', - }, { xtype: 'pmxACMEPluginSelector', name: 'plugin', @@ -170,6 +168,14 @@ Ext.define('Proxmox.window.ACMEDomainEdit', { value: '', fieldLabel: gettext('Domain'), }, + { + xtype: 'proxmoxtextfield', + name: 'alias', + disabled: true, + hidden: true, + fieldLabel: gettext('Alias'), + emptyText: Proxmox.Utils.noneText, + }, { xtype: 'combobox', name: 'usage', -- 2.43.0