From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id D26D71FF0AD for ; Sun, 04 Oct 2026 13:58:40 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 78425216D9; Sun, 04 Oct 2026 13:58:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dualfroz.com; s=dkim; t=1791115093; h=from:subject:date:message-id:to:mime-version: content-transfer-encoding:in-reply-to:references; bh=51hZ5thVSgavvtthix8V7jR6MRBCsFbZlpCXeSaJiZs=; b=ojPyDQoEAAf+l+/f26HSI0struN2iYXZhm9u5yY/ZnijLqP1iEnqYlUEAJnDnYyjwoJAR+ 5cxsSQ9n0A8UwrFafCqAewCuJsFo9+gK9uiSC/VSOeSrdtJbjyQgOjhb+WIRG95pt54QPa O4q/Pv2LQCrh2imKQTt1/Cv7s5g53OFNOa7GzXsFD/MKWF79Z7hFk6UrEzjM0wBkWM1tMm 2c7njZfUz9xiQsoekY6zWSHSdrq3ads0LvJoueirZj4/Z2HajYduogqgPHwi5Y5buVHvVg RgeMUWvBFYSrAYeAeWmoTJLvEMJQTIs3h4pa1LVfaRq3vXGuB3Agqqm5QR0mgQ== From: Michal Fox To: pve-devel@lists.proxmox.com Subject: [PATCH manager 1/2] fix #4588: ui: acme: allow setting the alias of DNS domains Date: Sun, 4 Oct 2026 11:58:08 +0000 Message-ID: <20261004115809.7-2-me@dualfroz.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261004115809.7-1-me@dualfroz.com> References: <20261004115809.7-1-me@dualfroz.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.213 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5JUKNSAZHF6C6OUHGLKHZUU34PEBX5FR X-Message-ID-Hash: 5JUKNSAZHF6C6OUHGLKHZUU34PEBX5FR X-MailFrom: me@dualfroz.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Domains validated with the DNS challenge can have an alias, so that the challenge record is created on another domain, which the '_acme-challenge' record of the domain points to with a CNAME. This is useful if the DNS plugin should not be able to update the zone of the domain itself. But the alias could only be set on the CLI, as the edit window only kept an existing one in a hidden field. Show it as a text field for domains with the DNS challenge type, like the plugin. Signed-off-by: Michal Fox --- Tested in the browser with the domain edit window: the field is only shown for DNS domains, an existing alias gets loaded, a cleared alias is removed from the property string, and none is submitted for HTTP domains. www/manager6/node/ACME.js | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/www/manager6/node/ACME.js b/www/manager6/node/ACME.js index 773d0d29..7194fd01 100644 --- a/www/manager6/node/ACME.js +++ b/www/manager6/node/ACME.js @@ -332,16 +332,14 @@ Ext.define('PVE.node.ACMEDomainEdit', { change: function (cb, value) { let me = this; let view = me.up('pveACMEDomainEdit'); - let pluginField = view.down('field[name=plugin]'); - pluginField.setDisabled(value !== 'dns'); - pluginField.setHidden(value !== 'dns'); + for (const name of ['plugin', 'alias']) { + let field = view.down(`field[name=${name}]`); + field.setDisabled(value !== 'dns'); + field.setHidden(value !== 'dns'); + } }, }, }, - { - xtype: 'hidden', - name: 'alias', - }, { xtype: 'pveACMEPluginSelector', name: 'plugin', @@ -357,6 +355,14 @@ Ext.define('PVE.node.ACMEDomainEdit', { value: '', fieldLabel: gettext('Domain'), }, + { + xtype: 'proxmoxtextfield', + name: 'alias', + disabled: true, + hidden: true, + fieldLabel: gettext('Alias'), + emptyText: Proxmox.Utils.noneText, + }, ], }, ], -- 2.43.0