From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 5FDC51FF0A3 for ; Thu, 01 Oct 2026 10:42:49 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id DA49F21B86; Thu, 01 Oct 2026 10:39:27 +0200 (CEST) From: Lukas Wagner To: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com Subject: [PATCH proxmox-perl-rs v2 25/34] notify: move proxmox-notify bindings from common to pve-rs Date: Thu, 1 Oct 2026 10:36:57 +0200 Message-ID: <20261001083706.144246-26-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261001083706.144246-1-l.wagner@proxmox.com> References: <20261001083706.144246-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790843857469 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.413 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: STVILD6GEXFM4LKHHQBUGJUWYLYBORBW X-Message-ID-Hash: STVILD6GEXFM4LKHHQBUGJUWYLYBORBW X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: PMG neither uses the notification stack, nor is it planned in the near future. Shipping the bindings in 'common' is awkward, since it then requires us to use the same feature flags in proxmox-notify for both, PVE and PMG. This reduces the number of dependencies for pmg-rs from 297 to 269, all of the removed ones were unused before. The module prefix changes from Proxmox::RS::Notify to PVE::RS::Notify, which is a breaking change that requires changes in the callers. Signed-off-by: Lukas Wagner --- common/pkg/Makefile | 1 - common/src/bindings/mod.rs | 3 --- pmg-rs/Cargo.toml | 1 - pve-rs/Makefile | 1 + pve-rs/src/bindings/mod.rs | 3 +++ {common => pve-rs}/src/bindings/notify.rs | 8 ++++---- 6 files changed, 8 insertions(+), 9 deletions(-) rename {common => pve-rs}/src/bindings/notify.rs (99%) diff --git a/common/pkg/Makefile b/common/pkg/Makefile index 5a537f9..1fce22f 100644 --- a/common/pkg/Makefile +++ b/common/pkg/Makefile @@ -23,7 +23,6 @@ PERLMOD_GENPACKAGE := /usr/lib/perlmod/genpackage.pl \ PERLMOD_PACKAGES := \ Proxmox::RS::APT::Repositories \ Proxmox::RS::CalendarEvent \ - Proxmox::RS::Notify \ Proxmox::RS::OIDC \ Proxmox::RS::SharedCache \ Proxmox::RS::Subscription diff --git a/common/src/bindings/mod.rs b/common/src/bindings/mod.rs index e0d1a3b..f122b9a 100644 --- a/common/src/bindings/mod.rs +++ b/common/src/bindings/mod.rs @@ -8,9 +8,6 @@ pub use apt_repositories::proxmox_rs_apt_repositories; mod calendar_event; pub use calendar_event::proxmox_rs_calendar_event; -mod notify; -pub use notify::proxmox_rs_notify; - mod oidc; pub use oidc::proxmox_rs_oidc; diff --git a/pmg-rs/Cargo.toml b/pmg-rs/Cargo.toml index 23be254..f88a204 100644 --- a/pmg-rs/Cargo.toml +++ b/pmg-rs/Cargo.toml @@ -35,7 +35,6 @@ proxmox-config-digest = "1" proxmox-http = { version = "1", features = ["client-sync", "client-trait"] } proxmox-http-error = "1" proxmox-log = "1" -proxmox-notify = "1" proxmox-openid = "1" proxmox-shared-cache = "1" proxmox-subscription = "1.0.2" diff --git a/pve-rs/Makefile b/pve-rs/Makefile index bb1cd2d..4c183c8 100644 --- a/pve-rs/Makefile +++ b/pve-rs/Makefile @@ -27,6 +27,7 @@ PERLMOD_GENPACKAGE := /usr/lib/perlmod/genpackage.pl \ PERLMOD_PACKAGES := \ PVE::RS::Firewall::SDN \ + PVE::RS::Notify \ PVE::RS::NVML \ PVE::RS::OCI \ PVE::RS::OpenId \ diff --git a/pve-rs/src/bindings/mod.rs b/pve-rs/src/bindings/mod.rs index f922982..143a62b 100644 --- a/pve-rs/src/bindings/mod.rs +++ b/pve-rs/src/bindings/mod.rs @@ -19,6 +19,9 @@ pub mod firewall; mod sdn; pub use sdn::fabrics::pve_rs_sdn_fabrics; +mod notify; +pub use notify::pve_rs_notify; + #[allow(unused_imports)] pub use crate::common::bindings::*; diff --git a/common/src/bindings/notify.rs b/pve-rs/src/bindings/notify.rs similarity index 99% rename from common/src/bindings/notify.rs rename to pve-rs/src/bindings/notify.rs index 409270a..ba713e3 100644 --- a/common/src/bindings/notify.rs +++ b/pve-rs/src/bindings/notify.rs @@ -1,6 +1,6 @@ -#[perlmod::package(name = "Proxmox::RS::Notify")] -pub mod proxmox_rs_notify { - //! The `Proxmox::RS::Notify` package. +#[perlmod::package(name = "PVE::RS::Notify")] +pub mod pve_rs_notify { + //! The `PVE::RS::Notify` package. //! //! This implements the new notification API and support code. //! @@ -45,7 +45,7 @@ pub mod proxmox_rs_notify { config: Mutex, } - perlmod::declare_magic!(Box : &NotificationConfig as "Proxmox::RS::Notify"); + perlmod::declare_magic!(Box : &NotificationConfig as "PVE::RS::Notify"); /// Method: Support `dclone` so this can be put into the `ccache` of `PVE::Cluster`. #[export(name = "STORABLE_freeze", raw_return)] -- 2.47.3