From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id A030A1FF0C0 for ; Wed, 30 Sep 2026 16:52:02 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6903121663; Wed, 30 Sep 2026 16:51:54 +0200 (CEST) From: Elias Huhsovitz To: pve-devel@lists.proxmox.com Subject: [PATCH manager 1/2] fix #7860: api: pool: do not delete when used by backup job Date: Wed, 30 Sep 2026 16:51:42 +0200 Message-ID: <20260930145143.210066-2-e.huhsovitz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260930145143.210066-1-e.huhsovitz@proxmox.com> References: <20260930145143.210066-1-e.huhsovitz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790779910142 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.573 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VOV3V5NELXBVSE2VIHS6UFJ623AOHHVD X-Message-ID-Hash: VOV3V5NELXBVSE2VIHS6UFJ623AOHHVD X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Elias Huhsovitz X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Currently, deleting a pool that is used by a backup is allowed. This results in a suboptimal configuration where calling the API endpoint `/cluster/backup-info/not-backed-up` fails, because it tries to query the VMs from the non-existent pool. Mitigate this issue by not allowing pools used by backups to be deleted. Signed-off-by: Elias Huhsovitz --- PVE/API2/Pool.pm | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/PVE/API2/Pool.pm b/PVE/API2/Pool.pm index 63aff5bb..a0ff8a31 100644 --- a/PVE/API2/Pool.pm +++ b/PVE/API2/Pool.pm @@ -475,6 +475,19 @@ __PACKAGE__->register_method({ }, }); +my sub check_pool_used_in_backup_job { + my ($pool) = @_; + + my $backup_jobs = cfs_read_file('jobs.cfg'); + + for my $job_id (keys $backup_jobs->{ids}->%*) { + my $referenced_pool = $backup_jobs->{ids}->{$job_id}->{pool}; + next if !defined($referenced_pool); + next if $referenced_pool ne $pool; + die "pool '$pool' is used in backup job '$job_id'\n"; + } +} + __PACKAGE__->register_method({ name => 'delete_pool', protected => 1, @@ -524,6 +537,8 @@ __PACKAGE__->register_method({ die "pool '$pool' is not empty (contains storage '$storeid')\n"; } + check_pool_used_in_backup_job($pool); + delete($usercfg->{pools}->{$pool}); PVE::AccessControl::delete_pool_acl($pool, $usercfg); -- 2.47.3