From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 5A47C1FF09B for ; Mon, 28 Sep 2026 09:16:49 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E0524218F2; Mon, 28 Sep 2026 09:15:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790340460; x=1790945260; darn=lists.proxmox.com; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=p/iMFQ8b7Szpa3so0FkYelSEWg4WELleIJcWP6icvB8=; b=Ll6ZLglkbxAVwbW9lQ+e/5DBL/9NfSgmrEz0ruVYREhtUW7PK2qUJbJXrnn5TSlrTx f57mLB1MEA+uozudEpxX4BOaWkY9qoytG3BbnUdkWtLlwkXOo9XQ/hWya0rt9HcQXWQg zTQ55salNazwfPlZrDNYgb8FCqT6kqCRlYKOy6GxTYXUMGRRs3heFWSqwZzgxw37Zksz l/4Qp3dG/vA2gx0FPt647Nh6Fcpt0yNs9FaAnsUzcDrnvowVRv5ZHHzAsVmZrwhI8d/T xolPGWgzTkN8ybVb2xtD+K2kP6jd3pSH/ZnKLDI4AJV2zqvUvMCO18bS4dQeFMR7MBJq Kjgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790340460; x=1790945260; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=p/iMFQ8b7Szpa3so0FkYelSEWg4WELleIJcWP6icvB8=; b=urACJzn+TnvTkxG2QqTY6lZdd9/XKi5AlyLEiQFTSAlStpxqe+crltfck5s92sOEFT mCQMJAVSyKpZkcYWxRCZW78+jkNUMlCJlQh9XgBzJXFeEL2E/zDyDiVAqco401iiV/HY bLRjQD58EiXwAoeNa5x3DuEUAZlDWHGoWVBrjaYsfWJvZrZYKD3KI6SRkCdnzxlHkI+J yRWM42YVrDaH78Sa/xCTp32/RAwBnonTSlRAOcLAVF1Cqqc9jdgxVvXWWNVVNYyvMNp6 3GONoe/bqMXj+7gssB0sE5zC8CMzcdrgCLWF4GEmOJ2/pG/vh6c/01bgCmLTeay4JQCZ XyGw== X-Gm-Message-State: AFuF++m50pXo9QnLid/X+9/dpD3NWgWXo0oGreTqlro10rPK0FQR+snM LubxJ8qJpCI3xIDa6/hqJkzZeSx3al87Q8YNf7T9b3fCuwPUWznD+mMpsQmfyIT6 X-Gm-Gg: AYBFou3D9N2aA+ok/vG6wunkMlImjvnvAk5mk8mloYJUNdcddeLX443x/sCVcrr2QIV 5vXG2z8Z9KcbCW9aTERyQa8mRDrNbW2zi7DivZpWghNcUKsqsiCakFq0+dWcdbRHQwt8AXSxzNG wJZ9j0Hw8jjsdhHb/0zV6rt0S4XPpfX0GvXEoY3tzh52Pgrwbga2K90JGdQBcrui1VBllDc43LI CKJCDG+417djoTjlh6uZ1vQ3eIY4KL3S/zpqJJ4ebTE7bOhLQ2f8YRNE1IqYbs+F/yD0ADqVFs1 ChsukD//1j7R+nj5zigXIZAoBJDKT3QOiPICHi5bbdOE8+gpy7x4vfMa3EzRCRBTXXVJNOhSuB7 RObrmbHeiIaLqVw1F/EAsjNR+XOA6P83VC8uZR3Zg9T+2fsuMo8Tvtbo9xHqvSgWj/simPbRdK1 kiAIDas+wuNKOTd5qAwu7Tsy1PNGnfE0rbBbXENvDTSERpgwri6++MiVXGjdqPTaDvA81E8ojcz bQZn2iiUqjW1f5XUuxXQu6ijHu3OuUd8feUQG8wM9qn0oaFwhY5nQ0307Bj X-Received: by 2002:a05:6000:2586:b0:486:e901:e59 with SMTP id ffacd0b85a97d-4887174c00amr10997399f8f.31.1790340459656; Fri, 25 Sep 2026 05:47:39 -0700 (PDT) From: Mathias Bartmann To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox-acme 2/3] acme: add missing _url_replace function Date: Fri, 25 Sep 2026 14:47:36 +0200 Message-ID: <20260925124737.42866-3-mathias.bartmann@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260925124737.42866-1-mathias.bartmann@gmail.com> References: <20260925124737.42866-1-mathias.bartmann@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.250 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record X-MailFrom: mathias.bartmann@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: 2DCEXXPDTCEUD7VPBIXNEDTC3APAO4SI X-Message-ID-Hash: 2DCEXXPDTCEUD7VPBIXNEDTC3APAO4SI X-Mailman-Approved-At: Mon, 28 Sep 2026 09:14:43 +0200 X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: dns_yc.sh (Yandex Cloud) pipes the header and payload of the JWT it signs through _url_replace to turn base64 into base64url, but the proxmox-acme shim does not define that helper. Add it as in upstream acme.sh. Signed-off-by: Mathias Bartmann --- src/proxmox-acme | 4 ++++ src/test/test-shim-helpers | 3 +++ 2 files changed, 7 insertions(+) diff --git a/src/proxmox-acme b/src/proxmox-acme index 00f4c06..7d776ce 100644 --- a/src/proxmox-acme +++ b/src/proxmox-acme @@ -28,6 +28,10 @@ _mktemp() { mktemp } +_url_replace() { + tr '/+' '_-' | tr -d '= ' +} + # Usage: hashalg [outputhex] # Output Base64-encoded digest _digest() { diff --git a/src/test/test-shim-helpers b/src/test/test-shim-helpers index b625a53..d4ec5a3 100755 --- a/src/test/test-shim-helpers +++ b/src/test/test-shim-helpers @@ -30,5 +30,8 @@ else fail "_mktemp does not create a writable temporary file" fi +[ "$(printf '%s' 'ab/c+d==' | $SHIM _url_replace)" = 'ab_c-d' ] || + fail "_url_replace does not convert base64 to base64url" + [ "$FAILED" -eq 0 ] || exit 1 echo "OK: proxmox-acme helpers behave like upstream acme.sh." -- 2.55.0