From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id AE04E1FF0B3 for ; Fri, 25 Sep 2026 11:42:59 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9CA3821713; Fri, 25 Sep 2026 11:42:36 +0200 (CEST) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH pve-firewall v3 02/16] parser: do not log errors for disabled rules Date: Fri, 25 Sep 2026 11:42:16 +0200 Message-ID: <20260925094230.844917-3-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260925094230.844917-1-a.bied-charreton@proxmox.com> References: <20260925094230.844917-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 2 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: SINYJ3ZAHGZBLSWEJZPGTOKUF2MYE446 X-Message-ID-Hash: SINYJ3ZAHGZBLSWEJZPGTOKUF2MYE446 X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The rule parser always logged errors when encountering them, even if the offending rule was disabled. As a preparatory step for implementing automatic disabling of rules with dangling references to IPSets or Aliases, avoid logging errors for disabled rules. Signed-off-by: Arthur Bied-Charreton --- src/PVE/Firewall.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index da6976e..a01738c 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -3384,7 +3384,7 @@ sub parse_fw_rule { die "unable to parse rule parameters: $line\n" if length($line); $rule = verify_rule($rule, $cluster_conf, $fw_conf, $rule_env, 1); - if ($rule->{errors}) { + if ($rule->{enable} && $rule->{errors}) { # The verbose flag really means we're running from the CLI and want # output on the console - in the other case we really want such errors # to go into the syslog instead. -- 2.47.3