From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 130491FF0AB for ; Wed, 23 Sep 2026 09:05:41 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 12B0621569; Wed, 23 Sep 2026 09:05:30 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v5 3/9] pci: nvidia vgpu: correct wrong comment about uuid Date: Wed, 23 Sep 2026 09:04:56 +0200 Message-ID: <20260923070522.434715-4-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260923070522.434715-1-d.csapak@proxmox.com> References: <20260923070522.434715-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.450 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: K2FQLHTAODH2CFVWBF2ZHDEBGNZ75DZ6 X-Message-ID-Hash: K2FQLHTAODH2CFVWBF2ZHDEBGNZ75DZ6 X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: At the time the mdev code was written, it was believed that the uuid of the qemu vm has to be the same as the mdev. This is obviously not true, since we already prefer the smbios uuid, and if more than one vGPU is given to a VM, this can't hold. So the comment must be wrong, and the nvidia driver simply expects *a* uuid, not the one of the mdev. Also, it's not named NVIDIA GRID anymore, so use the current vGPU terminology. Signed-off-by: Dominik Csapak Reviewed-by: Elias Huhsovitz Tested-by: Elias Huhsovitz Reviewed-by: Jakob Klocker Tested-by: Jakob Klocker --- src/PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 2f9eae6c..9f6a4d4c 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -5678,7 +5678,7 @@ sub vm_start_nolock { next if !$d->{mdev} && !$d->{nvidia}; die "could not create mediated device\n" if !defined($chosen_mdev); - # nvidia grid needs the uuid of the mdev as qemu parameter + # nvidia vgpu needs a uuid as qemu parameter if (!defined($uuid) && $chosen_mdev->{vendor} =~ m/^(0x)?10de$/) { $uuid = PVE::QemuServer::PCI::Mdev::generate_mdev_uuid($vmid, $index); } -- 2.47.3