From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id C5A541FF09C for ; Mon, 21 Sep 2026 17:36:00 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 0F5AA215AD; Mon, 21 Sep 2026 17:35:50 +0200 (CEST) From: Jakob Klocker To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 2/2] api: refuse moving disks if source VM is protected Date: Mon, 21 Sep 2026 17:35:45 +0200 Message-ID: <20260921153545.406664-3-j.klocker@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260921153545.406664-1-j.klocker@proxmox.com> References: <20260921153545.406664-1-j.klocker@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.706 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: IUWTWU25VWOXHYDVO5R3CPA5IUGFRJQZ X-Message-ID-Hash: IUWTWU25VWOXHYDVO5R3CPA5IUGFRJQZ X-MailFrom: jklocker@dev.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Moving a disk removes it from the source VM, which, according to the documentation, the protection flag prevents. Refuse the move when the source is protected. Signed-off-by: Jakob Klocker --- src/PVE/API2/Qemu.pm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm index 922c6599..3cf3517b 100644 --- a/src/PVE/API2/Qemu.pm +++ b/src/PVE/API2/Qemu.pm @@ -5024,6 +5024,11 @@ __PACKAGE__->register_method({ my $target_conf = PVE::QemuConfig->load_config($target_vmid); PVE::QemuConfig->check_lock($target_conf); + PVE::QemuConfig->check_protection( + $source_conf, + "Can't move disks from protected VMs\n", + ); + die "Can't move disks from or to template VMs\n" if ($source_conf->{template} || $target_conf->{template}); -- 2.47.3