From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 044B81FF0C1 for ; Fri, 18 Sep 2026 18:11:07 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D060821806; Fri, 18 Sep 2026 18:08:59 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH container v3 19/21] pct: introduce mtunnel command Date: Fri, 18 Sep 2026 18:08:25 +0200 Message-ID: <20260918160841.128088-20-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260918160841.128088-1-f.ebner@proxmox.com> References: <20260918160841.128088-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1789747730703 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.584 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FZU3T3KVFGT5T6ARZXI47XLKB6WMDRTM X-Message-ID-Hash: FZU3T3KVFGT5T6ARZXI47XLKB6WMDRTM X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Similar to what we already have in qemu-server. There is a 'config' command used for checking that the configuration can be understood by the migration target. Signed-off-by: Fiona Ebner --- No changes in v3. src/PVE/CLI/pct.pm | 57 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index ceb0bea..00f9d48 100755 --- a/src/PVE/CLI/pct.pm +++ b/src/PVE/CLI/pct.pm @@ -12,6 +12,7 @@ use PVE::CLIHandler; use PVE::Cluster; use PVE::CpuSet; use PVE::Exception qw(raise_param_exc); +use PVE::File; use PVE::GuestHelpers; use PVE::INotify; use PVE::JSONSchema qw(get_standard_option); @@ -1053,6 +1054,60 @@ __PACKAGE__->register_method({ }, }); +__PACKAGE__->register_method({ + name => 'mtunnel', + path => 'mtunnel', + method => 'POST', + description => "For internal use by intra-cluster migration only.", + parameters => { + additionalProperties => 0, + properties => {}, + }, + returns => { type => 'null' }, + code => sub { + my ($param) = @_; + + if (!PVE::Cluster::check_cfs_quorum(1)) { + print "no quorum\n"; + return; + } + + my $tunnel_write = sub { + my $text = shift; + chomp $text; + print "$text\n"; + *STDOUT->flush(); + }; + + $tunnel_write->("tunnel online"); + $tunnel_write->("ver 1"); + + while (my $line = ) { + chomp $line; + if ($line =~ /^quit$/) { + $tunnel_write->("OK"); + last; + } elsif ($line =~ /^config (\d+) (\S+)$/) { + my ($vmid, $node) = ($1, $2); + eval { + my $conf_fn = PVE::LXC::Config->config_file($vmid, $node); + my $raw = PVE::File::file_get_contents($conf_fn); + PVE::LXC::Config::parse_pct_config($conf_fn, $raw, 1); + }; + if (my $err = $@) { + $tunnel_write->("ERR: strict config check for target node failed - $err"); + } else { + $tunnel_write->("OK"); + } + } else { + $tunnel_write->("ERR: unknown command '$line'"); + } + } + + return; + }, +}); + our $cmddef = { list => [ 'PVE::API2::LXC', @@ -1193,6 +1248,8 @@ our $cmddef = { rescan => [__PACKAGE__, 'rescan', []], cpusets => [__PACKAGE__, 'cpusets', []], fstrim => [__PACKAGE__, 'fstrim', ['vmid']], + + mtunnel => [__PACKAGE__, 'mtunnel', []], }; 1; -- 2.47.3