From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 8C3321FF0A7 for ; Wed, 16 Sep 2026 15:24:25 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3C020213AD; Wed, 16 Sep 2026 15:24:22 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH storage] lvm plugin: snapshot: don't quietly ignore failure to rename back to original Date: Wed, 16 Sep 2026 15:22:30 +0200 Message-ID: <20260916132303.154117-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1789565056531 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.632 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: U4LE3YBEWMPTA3GZ6DIHUYYLUNQ3X6X6 X-Message-ID-Hash: U4LE3YBEWMPTA3GZ6DIHUYYLUNQ3X6X6 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: In case the new top volume cannot be allocated, an error for renaming back to the original name was quietly ignored. Log it as a task warning, because this is important. Signed-off-by: Fiona Ebner --- src/PVE/Storage/LVMPlugin.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 67ba0f7..62f7997 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlugin.pm @@ -9,6 +9,7 @@ use IO::File; use JSON; use PVE::JSONSchema qw(get_standard_option); +use PVE::RESTEnvironment qw(log_warn); use PVE::Tools qw(run_command file_read_firstline trim); use PVE::Storage::Common; @@ -1136,9 +1137,9 @@ my sub volume_snapshot_locked { die "error rename $volname to $snap - $@\n" if $@; eval { alloc_snap_image($class, $storeid, $scfg, $volname, $snap) }; - if ($@) { - my $err = $@; + if (my $err = $@) { eval { $class->rename_snapshot($scfg, $storeid, $volname, $snap, 'current') }; + log_warn("unable to rename $snap back to to $volname - $@") if $@; die $err; } } -- 2.47.3