From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 5D0301FF09B for ; Mon, 14 Sep 2026 17:25:00 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7FE8021612; Mon, 14 Sep 2026 17:24:55 +0200 (CEST) From: Jonas Theisen To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v2 2/2] fix #8031: write APT proxy config on http_proxy change Date: Mon, 14 Sep 2026 17:24:12 +0200 Message-ID: <20260914152423.410631-3-j.theisen@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260914152423.410631-1-j.theisen@proxmox.com> References: <20260914152423.410631-1-j.theisen@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1789399468190 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.339 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6WS7FZVDZ65PPHWO73YYTGS4ZNUOP32B X-Message-ID-Hash: 6WS7FZVDZ65PPHWO73YYTGS4ZNUOP32B X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Writes the necessary file for APT if the http_proxy variable on the datacenter level is changed. This reuses the same function from the APT API for a regular database update. Signed-off-by: Jonas Theisen --- PVE/API2/Cluster.pm | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm index 4e5efbfd..8529c026 100644 --- a/PVE/API2/Cluster.pm +++ b/PVE/API2/Cluster.pm @@ -36,6 +36,7 @@ use PVE::API2::ClusterConfig; use PVE::API2::Firewall::Cluster; use PVE::API2::HAConfig; use PVE::API2::ReplicationConfig; +use PVE::API2::APT; my $have_sdn; eval { @@ -842,7 +843,11 @@ __PACKAGE__->register_method({ code => sub { my ($param) = @_; + my $http_proxy_change = 0; + my $delete = extract_param($param, 'delete'); + $http_proxy_change = 1 + if ((defined($param->{http_proxy})) || (defined($delete) && $delete =~ m/\bhttp_proxy\b/ )); cfs_lock_file( 'datacenter.cfg', @@ -859,6 +864,10 @@ __PACKAGE__->register_method({ ); die $@ if $@; + if ($http_proxy_change) { + PVE::API2::APT::update_apt_proxy_config(); + } + return undef; }, }); -- 2.47.3