From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id BED0B1FF09B for ; Mon, 14 Sep 2026 10:57:34 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 79CAE214A8; Mon, 14 Sep 2026 10:57:31 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v2 4/6] tests: hotplug: add cases for known defects Date: Mon, 14 Sep 2026 10:54:33 +0200 Message-ID: <20260914085725.1299009-5-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260914085725.1299009-1-d.csapak@proxmox.com> References: <20260914085725.1299009-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.477 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XZSDSUPFXHHJZEFLDSWHBEIKJ2HTAK4P X-Message-ID-Hash: XZSDSUPFXHHJZEFLDSWHBEIKJ2HTAK4P X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: adds some test cases that highlight currently known defects: * for older machine versions (< 11.1) adding scsi14 with an lsi controller tries to hotplug a bridge and fails * hotplugging a tablet device into an aarch64 vm results in errors due to wrong parameter use of a function. The tests don't fail, but record the faulty behavior. The first is fixed in newer machine versions, the fix for the second is a separate patch. Signed-off-by: Dominik Csapak --- src/test/hotplug/aarch64/tablet-enable.conf | 23 +++++++++++++++++++ .../aarch64/tablet-enable.conf.expected | 1 + src/test/hotplug/disk-add-scsi14-old.conf | 17 ++++++++++++++ .../hotplug/disk-add-scsi14-old.conf.expected | 1 + 4 files changed, 42 insertions(+) create mode 100644 src/test/hotplug/aarch64/tablet-enable.conf create mode 100644 src/test/hotplug/aarch64/tablet-enable.conf.expected create mode 100644 src/test/hotplug/disk-add-scsi14-old.conf create mode 100644 src/test/hotplug/disk-add-scsi14-old.conf.expected diff --git a/src/test/hotplug/aarch64/tablet-enable.conf b/src/test/hotplug/aarch64/tablet-enable.conf new file mode 100644 index 00000000..443cae77 --- /dev/null +++ b/src/test/hotplug/aarch64/tablet-enable.conf @@ -0,0 +1,23 @@ +# TEST: enabling the tablet device on aarch64 hotplugs tablet and keyboard +# HOST_ARCH: aarch64 +# EXPECTED_ERROR: tablet: hotplug problem - Too few arguments for subroutine 'PVE::QemuServer::QMPHelpers::qemu_deviceadd' (got 1; expected 2) +# STAYS_PENDING: 1 +arch: aarch64 +bios: ovmf +bootdisk: scsi0 +cores: 2 +efidisk0: local:8006/vm-8006-disk-2.qcow2,efitype=4m +machine: virt-10.1 +memory: 2048 +name: hotplug +net0: virtio=A2:C0:43:77:08:A0,bridge=vmbr0 +ostype: l26 +scsi0: local:8006/vm-8006-disk-0.qcow2,size=32G +scsihw: virtio-scsi-pci +smbios1: uuid=7b10d7af-b932-4c66-b2c3-3996152ec465 +sockets: 1 +tablet: 0 +vmgenid: c773c261-d800-4348-9f5d-167fadd53cf8 + +[PENDING] +tablet: 1 diff --git a/src/test/hotplug/aarch64/tablet-enable.conf.expected b/src/test/hotplug/aarch64/tablet-enable.conf.expected new file mode 100644 index 00000000..800f9296 --- /dev/null +++ b/src/test/hotplug/aarch64/tablet-enable.conf.expected @@ -0,0 +1 @@ +hmp device_add driver=usb-tablet,id=tablet,bus=uhci.0,port=1 diff --git a/src/test/hotplug/disk-add-scsi14-old.conf b/src/test/hotplug/disk-add-scsi14-old.conf new file mode 100644 index 00000000..febda9da --- /dev/null +++ b/src/test/hotplug/disk-add-scsi14-old.conf @@ -0,0 +1,17 @@ +# TEST: hotplugging a SCSI disk whose new LSI controller needs a hotplugged PCI bridge fails on QEMU < 11.1 +# EXPECTED_ERROR: scsi14: hotplug problem - can't hotplug bridge necessary for 'scsihw2' +# STAYS_PENDING: 1 +bootdisk: scsi0 +cores: 2 +machine: pc-i440fx-11.0 +memory: 2048 +name: hotplug +net0: virtio=A2:C0:43:77:08:A0,bridge=vmbr0 +ostype: l26 +scsi0: local:8006/vm-8006-disk-0.qcow2,size=32G +smbios1: uuid=7b10d7af-b932-4c66-b2c3-3996152ec465 +sockets: 1 +vmgenid: c773c261-d800-4348-9f5d-167fadd53cf8 + +[PENDING] +scsi14: local:8006/vm-8006-disk-1.qcow2,size=32G diff --git a/src/test/hotplug/disk-add-scsi14-old.conf.expected b/src/test/hotplug/disk-add-scsi14-old.conf.expected new file mode 100644 index 00000000..668a44fb --- /dev/null +++ b/src/test/hotplug/disk-add-scsi14-old.conf.expected @@ -0,0 +1 @@ +storage activate_volumes ["local:8006/vm-8006-disk-1.qcow2"] -- 2.47.3