From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id C35E61FF09B for ; Mon, 14 Sep 2026 09:34:22 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4C00A214F1; Mon, 14 Sep 2026 09:34:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789295109; x=1789899909; darn=lists.proxmox.com; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=A852dwlGspL0DPxaX+SKCRRBq4z81yhSdInvcH4bSKc=; b=oYZgQrw67l7lXiw8Gp5vkEv2oUeDG+Wu1cybJNuj9LPhOEm+cYnM5zdqDqm77mAA8m yOp3DigOyddWrgV3NaovHXgh/pR54Ia2uz+KxibR0Ux0FeLXYy0VJ8EtJ3+62dlQ2eKw 0OfRTcPXOTDzeqOVKKmyrB+LkMpGkS9Ok7d98/zWgbqep34AFcWLbQIBgV5rFWqd1Tcy PRIJr59yXp7mlMfwCfRKiKBMjAXMdX7EFEsvrzOOieah7Af10GVzir1Oz5wg6oxH4RBM bO4SlMlMrR7yfJJr1D8/9LZ5Ic1tKFoeNmYxafzQF5TRSAARthdDPsNGIZoMA2T419EJ qeMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789295109; x=1789899909; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=A852dwlGspL0DPxaX+SKCRRBq4z81yhSdInvcH4bSKc=; b=JSTWWaZ8wiJseb5Op6eawKOXbyUePrN1cZ999eCljCU3MkhAy3ylzW2b8h8XBOkoIP F6EPKNT7QEqN+AdVqaq0AizfyknNyfjMuAkAn3//uUn/OuPWG0PjLI9j4jo0Bpdl2tkJ d2n+5SI1d8io7Optex8Y7geFKFHoBpIBZP8Spcqntee1rNKjy1sOw/mIsCjNjnyithhj YQafj7uAWeK+Q2qDll6UGINF4r+kI9R4jQi4fkQkWJUX5WRsu/jCEG1fZTJvfzQmITx2 zUpCsuHOmpL9t06rWecjP1JxhOuiKm7OOGKItihkyq2BoHa2Ks12DOA7wOyKIEqjUAeo +8LA== X-Gm-Message-State: AFuF++n9TFRi1PE+Vd5BRl6AfJxLxqZrwgoKUAXK2Tep2lBXGltSSIft ar6leVtG76DNLwHNWW3GnSuHbx5bB7aV6k4tecFiA5B9pJzR7VJwpTiLvVvbVoR5B7w= X-Gm-Gg: AYBFou1W22E7ZdLsGpxMRWtJUj8XTRKUbGninngzLFrdG/PQC5iSGbMiKRjUc3sPe3N 7NpfgR5PHDmjyRmlN8YlUNSq+w52SCvk9swk+s2OS9fPda2ImAmKcSzKtO3piZx4B/E3Ivkb9aZ vz/sElDAGVTMeG68IH9Os6ZgUdicnlqsbeTOkElJQ8wnt/HsKBa3R1NTd59mInIaDx3b0dE4t5Q JKJPHchr1XUE9aCsarHdg0kbOpkCbUePyZT/wswAkipC/8GNzsPS7NOlW4CswHS5hrIJZwOKHxh e/Kr0JUUeJDGlPqx2JVGn52C6pyRasH2boGkycndccBZ9NTI2jXUtZW7DgtSM/Wz9Km0DUyCQeC VfNToW+7fOVYd4B2Ccjjy2C6h3YVp5A0FZ3A1DYxh9Jw9mkdev7DKCffp3UP4Ft3eSMDgRFBNb6 NCAT8xZyaPzHmSEJxbTNpwfh/fpmc0VXAivOhASnezpE339bXYuGbLgMjhYUK/RQlfY51pnXlwu dCvQliCH0tOEqdx8N033GM0QBuLfW/hK2fjtC2GPNrC20dNMZoE5N5WQsrsbv5bxeIFSmFTTt5j bja27Q== X-Received: by 2002:a05:600c:b95:b0:49e:65f2:db64 with SMTP id 5b1f17b1804b1-49e7602c6c5mr17951085e9.5.1789295108800; Sun, 13 Sep 2026 03:25:08 -0700 (PDT) From: Saeed Parhizkary To: pve-devel@lists.proxmox.com Subject: [PATCH] proxmox-acme: fix DNS plugin configuration parsing Date: Sun, 13 Sep 2026 13:54:55 +0330 Message-ID: <20260913102455.23235-1-saeed.parhizkary@gmail.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record X-MailFrom: saeed.parhizkary@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: AQUGL2K2RQA7XLMGUOMGV3P7RWPH4X4M X-Message-ID-Hash: AQUGL2K2RQA7XLMGUOMGV3P7RWPH4X4M X-Mailman-Approved-At: Mon, 14 Sep 2026 09:34:08 +0200 CC: Saeed Parhizkary X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The DNS plugin configuration parser currently splits each configuration line at the first '=' using shell word splitting. This causes values containing '=' to be truncated. Parse the key with ${line%%=*} and the value with ${line#*=} instead, so everything after the first '=' is preserved. This is required for DNS API credentials whose values may contain '='. Signed-off-by: Saeed Parhizkary --- src/proxmox-acme | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/proxmox-acme b/src/proxmox-acme index 705f7df..2160ca6 100644 --- a/src/proxmox-acme +++ b/src/proxmox-acme @@ -924,14 +924,12 @@ _json_decode() { # Proxmox implementation to inject the DNSAPI variables _load_plugin_config() { while IFS= read -r line; do - ADDR=(${line/=/ }) - key="${ADDR[0]}" - value="${ADDR[1]}" - - # acme.sh uses eval insted of export - if [ -n "$key" ]; then - export "$key"="$value" - fi + key="${line%%=*}" + value="${line#*=}" + + if [ -n "$key" ]; then + export "$key=$value" + fi done } -- 2.47.3