From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id AC9F71FF0B3 for ; Wed, 09 Sep 2026 12:43:32 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 2B9A721731; Wed, 09 Sep 2026 12:42:14 +0200 (CEST) From: Hannes Laimer To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v2 12/16] network: report NIC plug and unplug to SDN with the MAC Date: Wed, 9 Sep 2026 12:41:40 +0200 Message-ID: <20260909104144.1110031-13-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260909104144.1110031-1-h.laimer@proxmox.com> References: <20260909104144.1110031-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788950514092 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.549 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: RH5EO5OQGMLFRWWBUXU2QRKYJZ27CLGB X-Message-ID-Hash: RH5EO5OQGMLFRWWBUXU2QRKYJZ27CLGB X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The SDN layer answers DHCP on a plugged interface from the mapping of its guest NIC, and drops what it holds for the interface once it goes away. So the down script and the cleanup after a crash report through it. A bridge change keeps pve-common's unplug, allocates on the new vnet and pushes through the mapping call, whose push writes the dnsmasq reservation. The plug that follows tells the SDN layer where the interface went and carries the responder's record. This needs a libpve-network-perl with the SDN unplug. qemu-server lists the package as a versioned Recommends today while it cannot start a VM without it, so the floor is a Depends on that version. Signed-off-by: Hannes Laimer --- src/PVE/CLI/qm.pm | 4 ++-- src/PVE/QemuServer.pm | 4 ++++ src/PVE/QemuServer/Network.pm | 4 ++-- src/usr/pve-bridge | 8 +++++++- src/usr/pve-bridgedown | 4 ++-- 5 files changed, 17 insertions(+), 7 deletions(-) diff --git a/src/PVE/CLI/qm.pm b/src/PVE/CLI/qm.pm index b903c1f1..6c53581a 100755 --- a/src/PVE/CLI/qm.pm +++ b/src/PVE/CLI/qm.pm @@ -22,7 +22,7 @@ use PVE::GuestHelpers; use PVE::GuestImport::OVF; use PVE::INotify; use PVE::JSONSchema qw(get_standard_option); -use PVE::Network; +use PVE::Network::SDN::Zones; use PVE::RPCEnvironment; use PVE::SafeSyslog; use PVE::Tools qw(extract_param file_get_contents); @@ -1143,7 +1143,7 @@ __PACKAGE__->register_method({ foreach my $opt (keys %$conf) { next if $opt !~ m/^net(\d+)$/; my $interface = $1; - PVE::Network::tap_unplug("tap${vmid}i${interface}"); + PVE::Network::SDN::Zones::tap_unplug("tap${vmid}i${interface}"); } } diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 149f17be..360069f1 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -5158,6 +5158,9 @@ sub vmconfig_update_net { PVE::Network::SDN::Vnets::add_next_free_cidr( $newnet->{bridge}, $conf->{name}, $newnet->{macaddr}, $vmid, undef, 1, ); + PVE::Network::SDN::Vnets::add_dhcp_mapping( + $newnet->{bridge}, $newnet->{macaddr}, $vmid, $conf->{name}, + ); } PVE::QemuServer::Network::tap_plug( @@ -5167,6 +5170,7 @@ sub vmconfig_update_net { $newnet->{firewall}, $newnet->{trunks}, $newnet->{rate}, + { mac => $newnet->{macaddr} }, ); } elsif (safe_num_ne($oldnet->{rate}, $newnet->{rate})) { diff --git a/src/PVE/QemuServer/Network.pm b/src/PVE/QemuServer/Network.pm index b4893c01..cc76cfb3 100644 --- a/src/PVE/QemuServer/Network.pm +++ b/src/PVE/QemuServer/Network.pm @@ -349,10 +349,10 @@ sub delete_ifaces_ipams_ips { } sub tap_plug { - my ($iface, $bridge, $tag, $firewall, $trunks, $rate) = @_; + my ($iface, $bridge, $tag, $firewall, $trunks, $rate, $opts) = @_; $firewall = $firewall && PVE::Firewall::Helpers::needs_fwbr($bridge); - PVE::Network::SDN::Zones::tap_plug($iface, $bridge, $tag, $firewall, $trunks, $rate); + PVE::Network::SDN::Zones::tap_plug($iface, $bridge, $tag, $firewall, $trunks, $rate, $opts); } sub get_nets_host_mtu { diff --git a/src/usr/pve-bridge b/src/usr/pve-bridge index c7260c6b..20724271 100755 --- a/src/usr/pve-bridge +++ b/src/usr/pve-bridge @@ -43,7 +43,13 @@ die "unable to parse network config '$netid'\n" if !$net; PVE::Network::SDN::Vnets::add_dhcp_mapping($net->{bridge}, $net->{macaddr}, $vmid, $conf->{name}); PVE::Network::SDN::Zones::tap_create($iface, $net->{bridge}); PVE::QemuServer::Network::tap_plug( - $iface, $net->{bridge}, $net->{tag}, $net->{firewall}, $net->{trunks}, $net->{rate}, + $iface, + $net->{bridge}, + $net->{tag}, + $net->{firewall}, + $net->{trunks}, + $net->{rate}, + { mac => $net->{macaddr} }, ); exit 0; diff --git a/src/usr/pve-bridgedown b/src/usr/pve-bridgedown index e867b640..79a3722b 100755 --- a/src/usr/pve-bridgedown +++ b/src/usr/pve-bridgedown @@ -2,7 +2,7 @@ use strict; use warnings; -use PVE::Network; +use PVE::Network::SDN::Zones; my $iface = shift; @@ -11,6 +11,6 @@ die "no interface specified\n" if !$iface; die "got strange interface name '$iface'\n" if $iface !~ m/^tap(\d+)i(\d+)$/; -PVE::Network::tap_unplug($iface); +PVE::Network::SDN::Zones::tap_unplug($iface); exit 0; -- 2.47.3