From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 1473F1FF0AB for ; Mon, 07 Sep 2026 11:49:03 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 10C2C21595; Mon, 07 Sep 2026 11:48:02 +0200 (CEST) From: Erik Fastermann To: pve-devel@lists.proxmox.com Subject: [PATCH qemu v2 8/9] savevm-async: include reason when file open fails Date: Mon, 7 Sep 2026 11:47:42 +0200 Message-ID: <20260907094744.131193-9-e.fastermann@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260907094744.131193-1-e.fastermann@proxmox.com> References: <20260907094744.131193-1-e.fastermann@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.468 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: 52GUEMPUBDFLES3V7G3VG5GMLWPAWEYF X-Message-ID-Hash: 52GUEMPUBDFLES3V7G3VG5GMLWPAWEYF X-MailFrom: efastermann@ruth.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Erik Fastermann X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: blk_new_open() reports why it could not open the file, but the error was discarded. Signed-off-by: Erik Fastermann --- ...m-async-for-background-state-snapshots.patch | 17 ++++++++++------- ...E-add-optional-buffer-size-to-QEMUFile.patch | 6 +++--- ...euse-migration-blocker-check-for-snaps.patch | 2 +- 3 files changed, 14 insertions(+), 11 deletions(-) diff --git a/debian/patches/pve/0017-PVE-add-savevm-async-for-background-state-snapshots.patch b/debian/patches/pve/0017-PVE-add-savevm-async-for-background-state-snapshots.patch index d21fb1f..94908d7 100644 --- a/debian/patches/pve/0017-PVE-add-savevm-async-for-background-state-snapshots.patch +++ b/debian/patches/pve/0017-PVE-add-savevm-async-for-background-state-snapshots.patch @@ -39,7 +39,8 @@ Signed-off-by: Stefan Reiter Signed-off-by: Fiona Ebner [EF: drop QIOChannel reference free migration vmdesc - release resources on start failure path] + release resources on start failure path + include reason when file open fails] Signed-off-by: Erik Fastermann --- hmp-commands-info.hx | 13 + @@ -47,13 +48,13 @@ Signed-off-by: Erik Fastermann include/migration/snapshot.h | 2 + include/monitor/hmp.h | 3 + migration/meson.build | 1 + - migration/savevm-async.c | 632 +++++++++++++++++++++++++++++++++++ + migration/savevm-async.c | 634 +++++++++++++++++++++++++++++++++++ monitor/hmp-cmds.c | 38 +++ qapi/migration.json | 34 ++ qapi/misc.json | 25 ++ qemu-options.hx | 12 + system/vl.c | 10 + - 11 files changed, 787 insertions(+) + 11 files changed, 789 insertions(+) create mode 100644 migration/savevm-async.c diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx @@ -151,10 +152,10 @@ index 0222d5ea6e..90d62d5723 100644 ), gnutls, zlib) diff --git a/migration/savevm-async.c b/migration/savevm-async.c new file mode 100644 -index 0000000000..d688fc7112 +index 0000000000..56c60b345f --- /dev/null +++ b/migration/savevm-async.c -@@ -0,0 +1,632 @@ +@@ -0,0 +1,634 @@ +#include "qemu/osdep.h" +#include "migration/channel-savevm-async.h" +#include "migration/migration.h" @@ -570,7 +571,8 @@ index 0000000000..d688fc7112 + qdict_put_str(options, "driver", "raw"); + snap_state.target = blk_new_open(statefile, NULL, options, bdrv_oflags, &local_err); + if (!snap_state.target) { -+ error_setg(errp, "failed to open '%s'", statefile); ++ error_setg(errp, "failed to open '%s' - %s", statefile, ++ local_err ? error_get_pretty(local_err) : "unknown error"); + goto fail; + } + target_bs = blk_bs(snap_state.target); @@ -729,7 +731,8 @@ index 0000000000..d688fc7112 + be = blk_new_open(filename, NULL, options, 0, &local_err); + + if (!be) { -+ error_setg(errp, "Could not open VM state file"); ++ error_setg(errp, "Could not open VM state file - %s", ++ local_err ? error_get_pretty(local_err) : "unknown error"); + goto the_end; + } + diff --git a/debian/patches/pve/0018-PVE-add-optional-buffer-size-to-QEMUFile.patch b/debian/patches/pve/0018-PVE-add-optional-buffer-size-to-QEMUFile.patch index cac1842..4345f42 100644 --- a/debian/patches/pve/0018-PVE-add-optional-buffer-size-to-QEMUFile.patch +++ b/debian/patches/pve/0018-PVE-add-optional-buffer-size-to-QEMUFile.patch @@ -186,10 +186,10 @@ index a390554208..eda093b16a 100644 G_DEFINE_AUTOPTR_CLEANUP_FUNC(QEMUFile, qemu_fclose) diff --git a/migration/savevm-async.c b/migration/savevm-async.c -index d688fc7112..24f7ba60c9 100644 +index 56c60b345f..a460970dd5 100644 --- a/migration/savevm-async.c +++ b/migration/savevm-async.c -@@ -424,7 +424,7 @@ void qmp_savevm_start(const char *statefile, bool has_skip_vm_start, +@@ -425,7 +425,7 @@ void qmp_savevm_start(const char *statefile, bool has_skip_vm_start, QIOChannel *ioc = QIO_CHANNEL(qio_channel_savevm_async_new(snap_state.target, &snap_state.bs_pos)); @@ -198,7 +198,7 @@ index d688fc7112..24f7ba60c9 100644 object_unref(ioc); if (!snap_state.file) { -@@ -587,7 +587,7 @@ int load_snapshot_from_blockdev(const char *filename, Error **errp) +@@ -589,7 +589,7 @@ int load_snapshot_from_blockdev(const char *filename, Error **errp) /* restore the VM state */ QIOChannel *ioc = QIO_CHANNEL(qio_channel_savevm_async_new(be, &bs_pos)); diff --git a/debian/patches/pve/0046-savevm-async-reuse-migration-blocker-check-for-snaps.patch b/debian/patches/pve/0046-savevm-async-reuse-migration-blocker-check-for-snaps.patch index 98a0ca4..d87875b 100644 --- a/debian/patches/pve/0046-savevm-async-reuse-migration-blocker-check-for-snaps.patch +++ b/debian/patches/pve/0046-savevm-async-reuse-migration-blocker-check-for-snaps.patch @@ -136,7 +136,7 @@ index b6888daced..80eb0dcd1f 100644 bool migration_in_postcopy(void); bool migration_postcopy_is_alive(MigrationStatus state); diff --git a/migration/savevm-async.c b/migration/savevm-async.c -index 24f7ba60c9..78fc27b320 100644 +index a460970dd5..b703c5d5a3 100644 --- a/migration/savevm-async.c +++ b/migration/savevm-async.c @@ -390,7 +390,7 @@ void qmp_savevm_start(const char *statefile, bool has_skip_vm_start, -- 2.47.3