From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 579981FF0A5 for ; Fri, 04 Sep 2026 11:45:11 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 88AEF215C1; Fri, 04 Sep 2026 11:45:03 +0200 (CEST) From: Elias Huhsovitz To: pve-devel@lists.proxmox.com Subject: [PATCH manager v4 1/2] fix #6735: api: pci: allow mdevscan access via mapping permissions Date: Fri, 4 Sep 2026 11:44:53 +0200 Message-ID: <20260904094456.70309-2-e.huhsovitz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260904094456.70309-1-e.huhsovitz@proxmox.com> References: <20260904094456.70309-1-e.huhsovitz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788515095509 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.658 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TW2L24RWK7KJ5I4SPHGB7PWDUUNTFJSS X-Message-ID-Hash: TW2L24RWK7KJ5I4SPHGB7PWDUUNTFJSS X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Elias Huhsovitz X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The mdevscan endpoint requires Sys.Audit or Sys.Modify on '/'. This blocks non-admin users from listing mediated device types for a PCI mapping, even when they hold Mapping.Use on that mapping. Check the permission in the API handler based on the parameter type: For a raw PCI ID, require Sys.Audit or Sys.Modify on '/'. For a mapping, require Sys.Audit or Sys.Modify on '/', or fall back to requiring Mapping.Use, Mapping.Modify or Mapping.Audit on the specific mapping path. Set the endpoint permission to 'user => all' so the handler performs the type-dependent check. This keeps raw PCI IDs, which are not valid ACL paths, out of the declarative ACL evaluation. Signed-off-by: Elias Huhsovitz Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak --- PVE/API2/Hardware/PCI.pm | 44 ++++++++++++++++++++++++++++++---------- 1 file changed, 33 insertions(+), 11 deletions(-) diff --git a/PVE/API2/Hardware/PCI.pm b/PVE/API2/Hardware/PCI.pm index 36b9741b..eb83824f 100644 --- a/PVE/API2/Hardware/PCI.pm +++ b/PVE/API2/Hardware/PCI.pm @@ -3,13 +3,17 @@ package PVE::API2::Hardware::PCI; use strict; use warnings; +use PVE::Exception qw(raise raise_perm_exc); use PVE::JSONSchema qw(get_standard_option); use PVE::QemuServer::PCI::Mdev; use PVE::RESTHandler; +use PVE::RPCEnvironment; use base qw(PVE::RESTHandler); +use constant GLOBAL_PERMS => ['Sys.Audit', 'Sys.Modify']; + my $default_class_blacklist = "05;06;0b"; __PACKAGE__->register_method({ @@ -180,7 +184,11 @@ __PACKAGE__->register_method({ protected => 1, proxyto => "node", permissions => { - check => ['perm', '/', ['Sys.Audit', 'Sys.Modify'], any => 1], + description => + "For a PCI ID, requires 'Sys.Audit' or 'Sys.Modify' on '/'. For a mapping," + . " requires the same global permissions, or 'Mapping.Use', 'Mapping.Modify'" + . ", or 'Mapping.Audit' on '/mapping/pci/'.", + user => 'all', }, parameters => { additionalProperties => 0, @@ -222,20 +230,35 @@ __PACKAGE__->register_method({ code => sub { my ($param) = @_; - if ($param->{'pci-id-or-mapping'} =~ - m/^(?:[0-9a-fA-F]{4}:)?[0-9a-fA-F]{2}:[0-9a-fA-F]{2}\.[0-9a-fA-F]$/ - ) { - return PVE::QemuServer::PCI::Mdev::get_mdev_types($param->{'pci-id-or-mapping'}); # PCI ID + my $id = $param->{'pci-id-or-mapping'}; + my $is_pci_id = + $id =~ m/^(?:[0-9a-fA-F]{4}:)?[0-9a-fA-F]{2}:[0-9a-fA-F]{2}\.[0-9a-fA-F]$/; + + my $rpcenv = PVE::RPCEnvironment::get(); + my $authuser = $rpcenv->get_user(); + + my $has_global_perms = $rpcenv->check_any($authuser, '/', GLOBAL_PERMS, 1); + + if ($is_pci_id) { + raise_perm_exc("/, " . join("|", GLOBAL_PERMS->@*)) if !$has_global_perms; + + return PVE::QemuServer::PCI::Mdev::get_mdev_types($id); } else { - my $mapping = $param->{'pci-id-or-mapping'}; + if (!$has_global_perms) { + $rpcenv->check_any( + $authuser, + "/mapping/pci/$id", + ['Mapping.Use', 'Mapping.Modify', 'Mapping.Audit'], + ); + } my $types = {}; - my $devices = PVE::Mapping::PCI::find_on_current_node($mapping); + my $devices = PVE::Mapping::PCI::find_on_current_node($id); for my $device ($devices->@*) { - my $id = $device->{path}; - next if $id =~ m/;/; # mdev not supported for multifunction devices + my $dev_id = $device->{path}; + next if $dev_id =~ m/;/; # mdev not supported for multifunction devices - my $device_types = PVE::QemuServer::PCI::Mdev::get_mdev_types($id); + my $device_types = PVE::QemuServer::PCI::Mdev::get_mdev_types($dev_id); for my $type_definition ($device_types->@*) { my $type = $type_definition->{type}; @@ -247,6 +270,5 @@ __PACKAGE__->register_method({ return [sort { $a->{type} cmp $b->{type} } values($types->%*)]; } - }, }); -- 2.47.3