From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id BFDE81FF09B for ; Mon, 31 Aug 2026 15:06:52 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 339D921331; Mon, 31 Aug 2026 15:06:52 +0200 (CEST) From: Hannes Laimer To: pve-devel@lists.proxmox.com Subject: [PATCH pve-network] sdn: dhcp: only regenerate if no cfg is undef Date: Mon, 31 Aug 2026 15:06:47 +0200 Message-ID: <20260831130647.1016625-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788181595066 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.799 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6NYPZG6VFPVLDTPVWLQGQJEDHHXGRB36 X-Message-ID-Hash: 6NYPZG6VFPVLDTPVWLQGQJEDHHXGRB36 X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Except for when there is no `.running-config` at all, these three can't really be `undef`, and that is what this guard should check. These three can either all be `undef`, or none. So this does not change behaviour, but should be a little clearer. Signed-off-by: Hannes Laimer --- src/PVE/Network/SDN/Dhcp.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Dhcp.pm b/src/PVE/Network/SDN/Dhcp.pm index 65e40d4..f6ce842 100644 --- a/src/PVE/Network/SDN/Dhcp.pm +++ b/src/PVE/Network/SDN/Dhcp.pm @@ -63,7 +63,7 @@ sub regenerate_config { my $zone_cfg = $cfg->{zones}; my $vnet_cfg = $cfg->{vnets}; my $subnet_cfg = $cfg->{subnets}; - return if !$zone_cfg && !$subnet_cfg; + return if !$zone_cfg || !$vnet_cfg || !$subnet_cfg; my $nodename = PVE::INotify::nodename(); -- 2.47.3