From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 129FB1FF0DF for ; Fri, 28 Aug 2026 13:33:50 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E8AAC2161E; Fri, 28 Aug 2026 13:33:06 +0200 (CEST) From: Gabriel Goller To: pve-devel@lists.proxmox.com Subject: [PATCH pve-network v3 09/13] sdn: controllers: rename isis domain to fabric_id Date: Fri, 28 Aug 2026 13:32:48 +0200 Message-ID: <20260828113255.176546-10-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260828113255.176546-1-g.goller@proxmox.com> References: <20260828113255.176546-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787916770993 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.477 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YIFCEMNMDK4GYYNY3PYZZBSF2VRAVHDT X-Message-ID-Hash: YIFCEMNMDK4GYYNY3PYZZBSF2VRAVHDT X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Rename the "domain" property to "fabric_id" in the ISIS controller to align with the ISIS fabric naming convention and enable sharing of proxmox-frr ISIS types between both components. The ISIS fabric and ISIS controller share basic configuration options, but previously used different property names ("fabric_id" vs "domain"). Since fabrics are hardcoded to use "fabric_id", standardize the controller to use the same naming. For this change to be backwards compatible libpve-rs-perl and libpve-network-perl will need to be updated in sync. Signed-off-by: Gabriel Goller --- src/PVE/Network/SDN/Controllers/IsisPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Controllers/IsisPlugin.pm b/src/PVE/Network/SDN/Controllers/IsisPlugin.pm index 272d55efbfc7..5ddbf4d32e69 100644 --- a/src/PVE/Network/SDN/Controllers/IsisPlugin.pm +++ b/src/PVE/Network/SDN/Controllers/IsisPlugin.pm @@ -90,7 +90,7 @@ sub generate_frr_config { for my $iface (sort @ifaces) { my $iface_name = $altnames->{$iface} // $iface; $config->{frr}->{isis}->{interfaces}->{$iface_name} //= {}; - $config->{frr}->{isis}->{interfaces}->{$iface_name}->{domain} = $isis_domain; + $config->{frr}->{isis}->{interfaces}->{$iface_name}->{fabric_id} = $isis_domain; $config->{frr}->{isis}->{interfaces}->{$iface_name}->{is_ipv4} = 1; $config->{frr}->{isis}->{interfaces}->{$iface_name}->{is_ipv6} = 0; } -- 2.47.3