From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 006821FF0B7 for ; Tue, 25 Aug 2026 13:03:14 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 8F0AD21605; Tue, 25 Aug 2026 13:03:05 +0200 (CEST) From: Nicolas Frey To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager 4/4] partially fix #7801: ui: hardware view: warn about problematic virtio versions Date: Tue, 25 Aug 2026 13:02:38 +0200 Message-ID: <20260825110238.215790-5-n.frey@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260825110238.215790-1-n.frey@proxmox.com> References: <20260825110238.215790-1-n.frey@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.997 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: WSUXRPKIWSOIKWREQN34G22KYPG7LLI2 X-Message-ID-Hash: WSUXRPKIWSOIKWREQN34G22KYPG7LLI2 X-MailFrom: nfrey@miso.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: based on whether the ostype is windows or not. extends the `editorFactory` to allow extraOptions to be a callback to allow for lazy evaluation. this is needed as 'ostype' is not yet instantiated when eagerly evaluating. Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=7801 Signed-off-by: Nicolas Frey --- www/manager6/qemu/HardwareView.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index e6c02299..ae09094f 100644 --- a/www/manager6/qemu/HardwareView.js +++ b/www/manager6/qemu/HardwareView.js @@ -805,7 +805,7 @@ Ext.define('PVE.qemu.HardwareView', { }; let editorFactory = (classPath, extraOptions) => { - extraOptions = extraOptions || {}; + extraOptions = (Ext.isFunction(extraOptions) ? extraOptions() : extraOptions) || {}; return () => Ext.create(`PVE.qemu.${classPath}`, { autoShow: true, @@ -847,7 +847,9 @@ Ext.define('PVE.qemu.HardwareView', { text: gettext('CD/DVD Drive'), iconCls: 'pve-itype-icon-cdrom', disabled: !caps.vms['VM.Config.CDROM'], - handler: editorFactory('CDEdit'), + handler: editorFactory('CDEdit', () => ({ + warnVirtio: PVE.Utils.is_windows(me.getObjectValue('ostype')), + })), }, { text: gettext('Network Device'), -- 2.47.3