From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id A15F31FF09B for ; Mon, 17 Aug 2026 16:24:34 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id B65D021590; Mon, 17 Aug 2026 16:24:19 +0200 (CEST) From: Lukas Sichert To: pve-devel@lists.proxmox.com Subject: [PATCH manager v4 0/3] fix #4503: add configurable detect-zeroes disk option Date: Mon, 17 Aug 2026 16:23:49 +0200 Message-ID: <20260817142408.111667-1-l.sichert@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786976632323 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.732 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: J4VPPB5QSDDSAJOKKY53LHWVFTSV5X46 X-Message-ID-Hash: J4VPPB5QSDDSAJOKKY53LHWVFTSV5X46 X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Lukas Sichert X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When discard is enabled, qemu-server defaults to detect-zeroes=unmap, which can negatively affect zero-write performance on some storage setups. This series allows users to disable zero detection while keeping guest discard/TRIM support enabled. The first patch extends propertyStringSet() to support properties which default to true. The second patch converts the existing backup option to use this handling. The final patch adds the detect-zeroes option to the disk editor. Buglink: https://bugzilla.proxmox.com/show_bug.cgi?id=4503 changes from v3 to v4 (thanks @Fiona): - split the change into a three-patch series - extend propertyStringSet() to support properties which default to true - use the new handling for the existing backup property - omit detect_zeroes when enabled and only serialize detect_zeroes=0 when explicitly disabled changes from v2 to v3 (thanks @Fabian): - add a comment explaining why this property is handled differently from the others changes from v1 to v2: - add the bug number to the commit header - append the buglink to the commit body manager: Lukas Sichert (3): ui: utils: support true defaults in propertyStringSet ui: qemu: refactor backup property handling fix #4503: ui: qemu: add detect zeroes disk option www/manager6/Utils.js | 4 ++-- www/manager6/qemu/HDEdit.js | 10 +++++++++- 2 files changed, 11 insertions(+), 3 deletions(-) Summary over all repositories: 2 files changed, 11 insertions(+), 3 deletions(-) -- Generated by murpp 0.12.0