From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 503681FF0EA for ; Thu, 13 Aug 2026 13:27:59 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id F05282161B; Thu, 13 Aug 2026 13:27:31 +0200 (CEST) From: Jakob Klocker To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager 5/6] ui: qemu: options: add editor for reboot behavior Date: Thu, 13 Aug 2026 13:27:16 +0200 Message-ID: <20260813112717.272254-6-j.klocker@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260813112717.272254-1-j.klocker@proxmox.com> References: <20260813112717.272254-1-j.klocker@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.521 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: VVUU7YMGRIKXFEKWXXQX5OM24AS7G746 X-Message-ID-Hash: VVUU7YMGRIKXFEKWXXQX5OM24AS7G746 X-MailFrom: jklocker@iris.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jakob Klocker X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The `reboot` option is now a property string with an added `powercycle` sub-property, so expose both in the VM options panel: one checkbox to allow reboots at all, and one to stop and start the VM on a guest-initated reboot instead of resetting it in place, which makes pending changes take effect. Signed-off-by: Jakob Klocker --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 17 +++++++ www/manager6/form/RebootFeatureSelector.js | 59 ++++++++++++++++++++++ www/manager6/qemu/Options.js | 14 +++++ 4 files changed, 91 insertions(+) create mode 100644 www/manager6/form/RebootFeatureSelector.js diff --git a/www/manager6/Makefile b/www/manager6/Makefile index eb0e9d9c..40f71b8c 100644 --- a/www/manager6/Makefile +++ b/www/manager6/Makefile @@ -67,6 +67,7 @@ JSSRC= \ form/PrivilegesSelector.js \ form/QemuBiosSelector.js \ form/QemuMachineSelector.js \ + form/RebootFeatureSelector.js \ form/RecordSearchField.js \ form/SDNControllerSelector.js \ form/SDNZoneSelector.js \ diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 040b5ae0..f10c26d5 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -1160,6 +1160,23 @@ Ext.define('PVE.Utils', { return Ext.Date.format(new Date(value * 1000), 'l d F Y H:i:s'); }, + render_reboot: function (value) { + let normal = gettext('Reboot normally'); + + if (value === undefined || value === '') { + return `${Proxmox.Utils.defaultText} (${normal})`; + } + + let props = PVE.Parser.parsePropertyString(value, 'enabled'); + if (!PVE.Parser.parseBoolean(props.enabled, 1)) { + return gettext('Shut down instead of rebooting'); + } + if (PVE.Parser.parseBoolean(props.powercycle, 0)) { + return gettext('Stop and start the VM on guest reboot'); + } + return normal; + }, + // render a timestamp or pending render_next_event: function (value) { if (!value) { diff --git a/www/manager6/form/RebootFeatureSelector.js b/www/manager6/form/RebootFeatureSelector.js new file mode 100644 index 00000000..88e93da3 --- /dev/null +++ b/www/manager6/form/RebootFeatureSelector.js @@ -0,0 +1,59 @@ +Ext.define('PVE.form.RebootFeatureSelector', { + extend: 'Proxmox.panel.InputPanel', + alias: ['widget.pveRebootFeatureSelector'], + + viewModel: {}, + + items: [ + { + xtype: 'proxmoxcheckbox', + boxLabel: gettext('Allow reboot'), + name: 'enabled', + reference: 'enabled', + uncheckedValue: 0, + }, + { + xtype: 'proxmoxcheckbox', + boxLabel: gettext('Stop and start the VM on guest reboot (applies pending changes)'), + name: 'powercycle', + uncheckedValue: 0, + bind: { + disabled: '{!enabled.checked}', + }, + disabled: true, + }, + { + xtype: 'displayfield', + userCls: 'pmx-hint', + value: gettext('The VM is shut down instead of rebooted and stays off.'), + bind: { + hidden: '{enabled.checked}', + }, + }, + ], + + onGetValues: function (values) { + let enabled = !Ext.isDefined(values.enabled) || String(values.enabled) === '1'; + let powercycle = String(values.powercycle) === '1'; + + // equivalent to the default, so don't write the option at all + if (enabled && !powercycle) { + return { delete: 'reboot' }; + } + + let props = { enabled: enabled ? 1 : 0 }; + if (powercycle) { + props.powercycle = 1; + } + + return { reboot: PVE.Parser.printPropertyString(props, 'enabled') }; + }, + + setValues: function (values) { + let res = PVE.Parser.parsePropertyString(values.reboot, 'enabled'); + if (!Ext.isDefined(res.enabled)) { + res.enabled = 1; + } + this.callParent([res]); + }, +}); diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js index 8a4721a0..4fd5d1bb 100644 --- a/www/manager6/qemu/Options.js +++ b/www/manager6/qemu/Options.js @@ -84,6 +84,20 @@ Ext.define('PVE.qemu.Options', { } : undefined, }, + reboot: { + header: gettext('Reboot behavior'), + defaultValue: '', + renderer: PVE.Utils.render_reboot, + editor: caps.vms['VM.Config.Options'] + ? { + xtype: 'proxmoxWindowEdit', + subject: gettext('Reboot behavior'), + onlineHelp: 'qm_reboot_behavior', + width: 350, + items: { xtype: 'pveRebootFeatureSelector', name: 'reboot' }, + } + : undefined, + }, ostype: { header: gettext('OS Type'), editor: caps.vms['VM.Config.Options'] -- 2.47.3