From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 876B51FF0EA for ; Thu, 13 Aug 2026 12:52:22 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id DD78B2157B; Thu, 13 Aug 2026 12:52:20 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Subject: [PATCH pve-apiclient 1/1] client: allow passing query parameters to delete calls Date: Thu, 13 Aug 2026 12:51:59 +0200 Message-ID: <20260813105200.139383-1-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786618321113 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.028 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UW534NRBBE22MPEZTOAX3YQKEL4V5XBP X-Message-ID-Hash: UW534NRBBE22MPEZTOAX3YQKEL4V5XBP X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Some DELETE endpoints in the PVE API use additional parameters, that are passed as a query string. The API client did not process any parameters passed to delete calls, making it impossible to use DELETE endpoints in the PVE API that rely on additional parameters (e.g. the DELETE endpoint in the SDN IPAM IP module). Signed-off-by: Stefan Hanreich --- src/PVE/APIClient/LWP.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/APIClient/LWP.pm b/src/PVE/APIClient/LWP.pm index d8472f7..216260a 100755 --- a/src/PVE/APIClient/LWP.pm +++ b/src/PVE/APIClient/LWP.pm @@ -332,6 +332,7 @@ sub call { ); } elsif ($method eq 'DELETE') { + $uri->query_form($param); $response = $ua->request(HTTP::Request::Common::DELETE($uri)); } else { raise("method $method not implemented\n"); -- 2.47.3