From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 189FC1FF0ED for ; Fri, 31 Jul 2026 12:30:57 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1A1EF21531; Fri, 31 Jul 2026 12:30:53 +0200 (CEST) From: Dietmar Maurer To: pve-devel@lists.proxmox.com Subject: [RFC pve-manager 16/27] ui: storage: allow switching the scan node of the NFS/CIFS scan combos Date: Fri, 31 Jul 2026 12:21:45 +0200 Message-ID: <20260731102156.3947857-17-dietmar@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260731102156.3947857-1-dietmar@proxmox.com> References: <20260731102156.3947857-1-dietmar@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 2 AWL -0.147 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: OD6MO3BI66GV66LWEFGQS47MCUWILC5U X-Message-ID-Hash: OD6MO3BI66GV66LWEFGQS47MCUWILC5U X-MailFrom: dietmar@zilli.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The iSCSI and LVM scan combos already support scanning from an arbitrary cluster node, but the NFS and CIFS share scanners have the node baked into the store proxy URL at creation time. Add a public setNodeName() so callers with an explicit scan node selector can redirect the scan. No behavior change for the existing edit dialogs. Signed-off-by: Dietmar Maurer --- www/manager6/storage/CIFSEdit.js | 10 ++++++++++ www/manager6/storage/NFSEdit.js | 10 ++++++++++ 2 files changed, 20 insertions(+) diff --git a/www/manager6/storage/CIFSEdit.js b/www/manager6/storage/CIFSEdit.js index 5fe3fefe..5e19bc16 100644 --- a/www/manager6/storage/CIFSEdit.js +++ b/www/manager6/storage/CIFSEdit.js @@ -72,6 +72,16 @@ Ext.define('PVE.storage.CIFSScan', { } }, + setNodeName: function (nodename) { + let me = this; + nodename = nodename || 'localhost'; + if (me.nodename !== nodename) { + me.nodename = nodename; + me.getStore().getProxy().setUrl(`/api2/json/nodes/${nodename}/scan/cifs`); + me.resetProxy(); + } + }, + initComponent: function () { var me = this; diff --git a/www/manager6/storage/NFSEdit.js b/www/manager6/storage/NFSEdit.js index 72db156f..af522d2b 100644 --- a/www/manager6/storage/NFSEdit.js +++ b/www/manager6/storage/NFSEdit.js @@ -33,6 +33,16 @@ Ext.define('PVE.storage.NFSScan', { me.nfsServer = server; }, + setNodeName: function (nodename) { + let me = this; + nodename = nodename || 'localhost'; + if (me.nodename !== nodename) { + me.nodename = nodename; + me.getStore().getProxy().setUrl(`/api2/json/nodes/${nodename}/scan/nfs`); + me.lastQuery = null; + } + }, + initComponent: function () { var me = this; -- 2.47.3