From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 616721FF0E2 for ; Thu, 30 Jul 2026 11:41:32 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E2F55214CD; Thu, 30 Jul 2026 11:41:16 +0200 (CEST) From: Elias Huhsovitz To: pve-devel@lists.proxmox.com Subject: [PATCH manager v3 0/2] fix #6855: ui: storage: add mount options field for nfs, cifs, cephfs Date: Thu, 30 Jul 2026 11:40:53 +0200 Message-ID: <20260730094055.57659-1-e.huhsovitz@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785404462132 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.129 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6EOF6ROLNUZ3EZF5IJP52EBCCMHXCDTR X-Message-ID-Hash: 6EOF6ROLNUZ3EZF5IJP52EBCCMHXCDTR X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Elias Huhsovitz X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Setting custom mount options for NFS, CIFS and CephFS storage requires users to use the CLI or edit `/etc/pve/storage.cfg`. This series adds a new `Mount Options` text field allowing users to add custom mount options directly via the web interface. The field is located in the `Advanced` section of the edit window. Bugzilla: https://bugzilla.proxmox.com/show_bug.cgi?id=6855 v2: https://lore.proxmox.com/pve-devel/20260723150316.168440-1-e.huhsovitz@proxmox.com/ v1: https://lore.proxmox.com/pve-devel/20260721121334.115027-1-e.huhsovitz@proxmox.com/ This version extends the UI update to CephFS for the sake of completion, as the backend API already exposes the options parameter for it. Additionally, it fixes a logic flaw where the remount warning hint was incorrectly displayed when adding a new storage. Patch 1/2 add mount options field for NFS and CIFS. Patch 2/2 add mount options field for CephFS. This was not mentioned in the original bug report, but users have encountered this issue before: https://forum.proxmox.com/threads/storage-cephfs-and-multiple-file-systems-passing-options.55018/ Changes v2 -> v3: - Extend the mount options UI field to CephFS for consistency, as the backend API already supports this parameter. - Fix the dynamic hint logic to only display when editing an existing storage and the configuration is actively changed. This prevents the hint from showing unnecessarily during initial creation. - Fix a typo in the commit message and harmonize formatting. Changes v1 -> v2: - Add a dynamic UI hint when a user changes the mount config or NFS version during an edit, informing them that a remount is required for changes to take effect. - Update emptyText placeholders to align with existing Proxmox VE UI conventions. - Add filtering of exact duplicate options (for example, "rdma, seal, rdma" becomes "rdma, seal"). Deep semantic deduplication (for example, "mount_timeout=60, mount_timeout=70") is omitted to preserve opaque mount options where such configurations might be desired by the underlying system. Note: This was already implemented in the v2 patch, but was accidentally omitted from the v1 -> v2 changelog. Comments that have not been implemented: - Automatic re-mount: Automatically triggering a remount could introduce unnecessary complexity and risk disrupting active I/O operations if a user modifies options while the storage is currently in use by running guests or backup jobs. If users need this functionality, it can be added in a separate, dedicated patch. Big Thanks to Max for reviewing the previous versions! Elias Huhsovitz (2): fix #6855: ui: storage: add mount options field for nfs amd smb/cifs ui: storage: add mount options field for cephfs www/manager6/storage/CIFSEdit.js | 69 ++++++++++++++++-- www/manager6/storage/CephFSEdit.js | 59 ++++++++++++++- www/manager6/storage/NFSEdit.js | 112 +++++++++++++++++++++++------ 3 files changed, 210 insertions(+), 30 deletions(-) -- 2.47.3