From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 339981FF0E6 for ; Fri, 24 Jul 2026 16:33:57 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E766421627; Fri, 24 Jul 2026 16:33:19 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 8/9] migrate: log messages from remote nbdstop command Date: Fri, 24 Jul 2026 16:32:29 +0200 Message-ID: <20260724143240.211130-9-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260724143240.211130-1-f.ebner@proxmox.com> References: <20260724143240.211130-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784903533689 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.205 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4IR2SSZNWWZSJ4NXOBYWPC3IXZQOXFBM X-Message-ID-Hash: 4IR2SSZNWWZSJ4NXOBYWPC3IXZQOXFBM X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The output was always ignored since the introduction of the command in 2016 with commit b74cad8a ("add live storage migration with vm migration"). But it's nicer to show messages from the remote side to detect failures and for debugging purposes. Signed-off-by: Fiona Ebner --- src/PVE/QemuMigrate.pm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/PVE/QemuMigrate.pm b/src/PVE/QemuMigrate.pm index ab930955..a252f848 100644 --- a/src/PVE/QemuMigrate.pm +++ b/src/PVE/QemuMigrate.pm @@ -1738,7 +1738,12 @@ sub phase3_cleanup { my $cmd = [@{ $self->{rem_ssh} }, 'qm', 'nbdstop', $vmid]; eval { - PVE::Tools::run_command($cmd, outfunc => sub { }, errfunc => sub { }); + PVE::Tools::run_command( + $cmd, + logfunc => sub { + $self->log('info', "[$self->{node}] $_[0]"); + }, + ); }; if (my $err = $@) { $self->log('err', $err); -- 2.47.3