From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id A91981FF0E6 for ; Fri, 24 Jul 2026 16:31:03 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7B4C1214DB; Fri, 24 Jul 2026 16:31:03 +0200 (CEST) From: David Riley To: pve-devel@lists.proxmox.com Subject: [PATCH pve-network v3 07/12] sdn: register api formats for zones and vnets Date: Fri, 24 Jul 2026 16:25:23 +0200 Message-ID: <20260724142528.109453-8-d.riley@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260724142528.109453-1-d.riley@proxmox.com> References: <20260724142528.109453-1-d.riley@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784903397761 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.091 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2GPDKEJVBZMVBQMMNQKJVUXPGJFM52H3 X-Message-ID-Hash: 2GPDKEJVBZMVBQMMNQKJVUXPGJFM52H3 X-MailFrom: d.riley@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Register JSONSchema format validators for both SDN zones and VNets, enabling the pool members API to verify these network identifiers. Prepare for #7294 to enable schema validation of pool resources. Signed-off-by: David Riley Reviewed-by: Daniel Kral Link: https://bugzilla.proxmox.com/show_bug.cgi?id=7294 --- src/PVE/Network/SDN/VnetPlugin.pm | 26 +++++++++++++++++++++++--- src/PVE/Network/SDN/Zones/Plugin.pm | 26 +++++++++++++++++++++++--- 2 files changed, 46 insertions(+), 6 deletions(-) diff --git a/src/PVE/Network/SDN/VnetPlugin.pm b/src/PVE/Network/SDN/VnetPlugin.pm index e041575..9b4e390 100644 --- a/src/PVE/Network/SDN/VnetPlugin.pm +++ b/src/PVE/Network/SDN/VnetPlugin.pm @@ -16,14 +16,34 @@ PVE::Cluster::cfs_register_file( sub { __PACKAGE__->write_config(@_); }, ); +my $sdn_vnet_id_pattern = '[a-zA-Z][a-zA-Z0-9]*[a-zA-Z0-9]'; +my $vnet_min_length = 2; +my $vnet_max_length = 8; + +sub pve_verify_sdn_vnet_id { + my ($vnet, $noerr) = @_; + + my $len = length($vnet); + + if ($vnet !~ m/^$sdn_vnet_id_pattern$/o || $len < $vnet_min_length || $len > $vnet_max_length) { + return undef if $noerr; + die "invalid SDN VNet '$vnet', must be $vnet_min_length-$vnet_max_length characters" + . " long, start with a letter, and contain only alphanumeric characters\n"; + } + return $vnet; +} + +PVE::JSONSchema::register_format('pve-sdn-vnet-id', \&pve_verify_sdn_vnet_id); + PVE::JSONSchema::register_standard_option( 'pve-sdn-vnet-id', { description => "The SDN vnet object identifier.", type => 'string', - pattern => '[a-zA-Z][a-zA-Z0-9]*[a-zA-Z0-9]', - minLength => 2, - maxLength => 8, + format => 'pve-sdn-vnet-id', + pattern => $sdn_vnet_id_pattern, + minLength => $vnet_min_length, + maxLength => $vnet_max_length, }, ); diff --git a/src/PVE/Network/SDN/Zones/Plugin.pm b/src/PVE/Network/SDN/Zones/Plugin.pm index 74a3384..d10db7e 100644 --- a/src/PVE/Network/SDN/Zones/Plugin.pm +++ b/src/PVE/Network/SDN/Zones/Plugin.pm @@ -19,14 +19,34 @@ PVE::Cluster::cfs_register_file( sub { __PACKAGE__->write_config(@_); }, ); +my $sdn_zone_id_pattern = '[a-zA-Z][a-zA-Z0-9]*[a-zA-Z0-9]'; +my $zone_min_length = 2; +my $zone_max_length = 8; + +sub pve_verify_sdn_zone_id { + my ($zone, $noerr) = @_; + + my $len = length($zone); + + if ($zone !~ m/^$sdn_zone_id_pattern$/o || $len < $zone_min_length || $len > $zone_max_length) { + return undef if $noerr; + die "invalid SDN zone '$zone', must be $zone_min_length-$zone_max_length characters long," + . " start with a letter, and contain only alphanumeric characters\n"; + } + return $zone; +} + +PVE::JSONSchema::register_format('pve-sdn-zone-id', \&pve_verify_sdn_zone_id); + PVE::JSONSchema::register_standard_option( 'pve-sdn-zone-id', { description => "The SDN zone object identifier.", type => 'string', - pattern => '[a-zA-Z][a-zA-Z0-9]*[a-zA-Z0-9]', - minLength => 2, - maxLength => 8, + format => 'pve-sdn-zone-id', + pattern => $sdn_zone_id_pattern, + minLength => $zone_min_length, + maxLength => $zone_max_length, }, ); -- 2.47.3