From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 1B7131FF0E3 for ; Tue, 21 Jul 2026 15:55:39 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id CBE98214B0; Tue, 21 Jul 2026 15:54:41 +0200 (CEST) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH pve-firewall 02/13] firewall: config: sort OPTIONS when serializing Date: Tue, 21 Jul 2026 15:53:56 +0200 Message-ID: <20260721135407.372150-3-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260721135407.372150-1-a.bied-charreton@proxmox.com> References: <20260721135407.372150-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 2 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: KHFFY3NL5BONIZMJI5VRAREYAL6FUCUI X-Message-ID-Hash: KHFFY3NL5BONIZMJI5VRAREYAL6FUCUI X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Until now, firewall config serialization was iterating over the options hash without sorting the keys, making the output non-deterministic. Iterate over the sorted keys instead in format_options. Signed-off-by: Arthur Bied-Charreton --- src/PVE/Firewall.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index 894a87b..6270771 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -3754,7 +3754,7 @@ my $format_options = sub { my $raw = ''; $raw .= "[OPTIONS]\n\n"; - foreach my $opt (keys %$options) { + foreach my $opt (sort keys %$options) { $raw .= "$opt: $options->{$opt}\n"; } $raw .= "\n"; -- 2.47.3