From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 3810D1FF130 for ; Mon, 20 Jul 2026 15:45:46 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 99918214AD; Mon, 20 Jul 2026 15:45:45 +0200 (CEST) From: Elias Huhsovitz To: pve-devel@lists.proxmox.com Subject: [PATCH access-control 1/2] fix #6510: api: acl: allow deleting ACLs for non-existent entities Date: Mon, 20 Jul 2026 15:45:34 +0200 Message-ID: <20260720134535.136172-2-e.huhsovitz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260720134535.136172-1-e.huhsovitz@proxmox.com> References: <20260720134535.136172-1-e.huhsovitz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784555117541 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.205 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PMFKRUWHW23HLUFOZIJUOHAJRIVDLOHO X-Message-ID-Hash: PMFKRUWHW23HLUFOZIJUOHAJRIVDLOHO X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Elias Huhsovitz X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When a user, group, or API token is deleted, the system usually cleans up the associated ACLs. However, edge cases like manual configuration edits can leave orphaned ACL entries in the cluster configuration. Currently, the `update_acl` API endpoint strictly validates the existence of the target entity before processing any request. If the entity is missing, the API throws an error (e.g., "user 'foo@pve' does not exist") and aborts the operation. This prevents administrators from cleaning up leftover ACLs through the API. Bypass the existence check when the `delete` flag is set. This change allows the API to remove orphaned ACL entries. Signed-off-by: Elias Huhsovitz --- src/PVE/API2/ACL.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/API2/ACL.pm b/src/PVE/API2/ACL.pm index c57dd38..01329f7 100644 --- a/src/PVE/API2/ACL.pm +++ b/src/PVE/API2/ACL.pm @@ -224,7 +224,7 @@ __PACKAGE__->register_method({ foreach my $group (split_list($param->{groups})) { die "group '$group' does not exist\n" - if !$cfg->{groups}->{$group}; + if !$param->{delete} && !$cfg->{groups}->{$group}; if ($param->{delete}) { delete($node->{groups}->{$group}->{$role}); @@ -237,7 +237,7 @@ __PACKAGE__->register_method({ my $username = PVE::AccessControl::verify_username($userid); die "user '$username' does not exist\n" - if !$cfg->{users}->{$username}; + if !$param->{delete} && !$cfg->{users}->{$username}; if ($param->{delete}) { delete($node->{users}->{$username}->{$role}); @@ -248,7 +248,7 @@ __PACKAGE__->register_method({ foreach my $tokenid (split_list($param->{tokens})) { my ($username, $token) = PVE::AccessControl::split_tokenid($tokenid); - PVE::AccessControl::check_token_exist($cfg, $username, $token); + PVE::AccessControl::check_token_exist($cfg, $username, $token) if !$param->{delete}; if ($param->{delete}) { delete $node->{tokens}->{$tokenid}->{$role}; -- 2.47.3