From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 2EE341FF138 for ; Mon, 20 Jul 2026 14:38:11 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 40CF721567; Mon, 20 Jul 2026 14:37:46 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager 02/16] resources: remove commented ipaddr resource type Date: Mon, 20 Jul 2026 14:36:51 +0200 Message-ID: <20260720123705.216089-3-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260720123705.216089-1-d.kral@proxmox.com> References: <20260720123705.216089-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784551005862 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.310 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3J3V6FWLOB7UT3DYYHFEIOFYIX3SKWIL X-Message-ID-Hash: 3J3V6FWLOB7UT3DYYHFEIOFYIX3SKWIL X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Since 85d36c36 ("remove ipaddr resource type") the ipaddr resource type has been commented out, which indicates that it is not intended to be used and should be removed. Even if it might be used in the future, it would need more rework to fit in the current HA stack. Signed-off-by: Daniel Kral --- src/PVE/HA/Resources.pm | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/src/PVE/HA/Resources.pm b/src/PVE/HA/Resources.pm index df7c1ff3..e63d78d8 100644 --- a/src/PVE/HA/Resources.pm +++ b/src/PVE/HA/Resources.pm @@ -189,30 +189,4 @@ sub get_static_stats_from_config { die "implement in subclass"; } -# package PVE::HA::Resources::IPAddr; - -# use strict; -# use warnings; -# use PVE::Tools qw($IPV4RE $IPV6RE); - -# use base qw(PVE::HA::Resources); - -# sub type { -# return 'ipaddr'; -# } - -# sub verify_name { -# my ($class, $name) = @_; - -# die "invalid IP address\n" if $name !~ m!^$IPV6RE|$IPV4RE$!; -# } - -# sub options { -# return { -# state => { optional => 1 }, -# group => { optional => 1 }, -# comment => { optional => 1 }, -# }; -# } - 1; -- 2.47.3