From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 9371F1FF0E5 for ; Wed, 15 Jul 2026 14:33:20 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C66F621429; Wed, 15 Jul 2026 14:33:19 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v2 1/1] fabrics: wireguard: node edit: use network selector Date: Wed, 15 Jul 2026 14:32:37 +0200 Message-ID: <20260715123239.139204-1-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784118748174 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.210 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: RF74GACXMNA2BZECYAKSQDEGDYW6BCGJ X-Message-ID-Hash: RF74GACXMNA2BZECYAKSQDEGDYW6BCGJ X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: For internal nodes, turn the endpoint form field into a network selector that allows users to select IP addresses from a dropdown. This makes the intention of the field clearer and also saves users some typing since they can just select any configured IP on the node without having to re-type it. The defaultFocus property is set for the node edit window, to avoid the network selector getting autofocused which leads to an ugly, mispositioned combogrid getting rendered automatically when the edit window gets rendered initially. Focus on the form can still be gained by pressing Tab an additional time. Suggested-by: Dominik Csapak Signed-off-by: Stefan Hanreich --- Notes: Changes from v1 (Thanks @Dominik): * fixed stray 'qqq' in label * made allowBlank always true, since it isn't necessary to set this dynamically. * properly set deleteEmpty / skipEmptyText for internal endpoint field .../sdn/fabrics/wireguard/NodeEdit.js | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js index fe4639ade..cc0f4cb38 100644 --- a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js +++ b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js @@ -27,6 +27,8 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', { }, }, + defaultFocus: 'no', + additionalItems: [ { xtype: 'proxmoxtextfield', @@ -56,12 +58,41 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', { allowBlank: false, }, { + // endpoint field for internal nodes + xtype: 'proxmoxNetworkSelector', + reference: 'networkSelector', + fieldLabel: gettext('Endpoint'), + emptyText: gettext('Host that peers connect to'), + labelWidth: 120, + name: 'endpoint', + type: 'any_bridge', + valueField: 'address', + displayField: 'address', + autoSelect: false, + notFoundIsValid: true, + editable: true, + allowBlank: true, + skipEmptyText: true, + bind: { + hidden: '{!current.isPveNode}', + disabled: '{!current.isPveNode}', + }, + cbind: { + deleteEmpty: '{!isCreate}', + }, + }, + { + // endpoint field for external nodes xtype: 'proxmoxtextfield', fieldLabel: gettext('Endpoint'), emptyText: gettext('Host that peers connect to'), labelWidth: 120, name: 'endpoint', allowBlank: false, + bind: { + hidden: '{current.isPveNode}', + disabled: '{current.isPveNode}', + }, }, { xtype: 'proxmoxtextfield', @@ -167,6 +198,13 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', { }, }, }, + listeners: { + change: function (_this, newValue) { + if (me.getViewModel().get('current.isPveNode')) { + me.lookupReference('networkSelector').setNodename(newValue); + } + }, + }, }); return config; -- 2.47.3