From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 4996D1FF150 for ; Mon, 06 Jul 2026 13:15:40 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 10D6F21478; Mon, 06 Jul 2026 13:15:34 +0200 (CEST) From: Elias Huhsovitz To: pve-devel@lists.proxmox.com Subject: [PATCH widget-toolkit 1/2] fix #7426: ui: network: use correct name tooltips for interface types Date: Mon, 6 Jul 2026 13:14:54 +0200 Message-ID: <20260706111455.106630-2-e.huhsovitz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260706111455.106630-1-e.huhsovitz@proxmox.com> References: <20260706111455.106630-1-e.huhsovitz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783336522574 X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WRVV7JLJBETY5BNQPXR7WUL7QM4SFX62 X-Message-ID-Hash: WRVV7JLJBETY5BNQPXR7WUL7QM4SFX62 X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Elias Huhsovitz X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The tooltip for the interface name field incorrectly showed VLAN examples (e.g., vmbr0.100) when creating a Provide accurate tooltips for Bridges, Bonds and VLANs. Signed-off-by: Elias Huhsovitz --- src/node/NetworkEdit.js | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js index c945139..b08d5ff 100644 --- a/src/node/NetworkEdit.js +++ b/src/node/NetworkEdit.js @@ -22,23 +22,23 @@ Ext.define('Proxmox.node.NetworkEdit', { me.isCreate = !me.iface; let iface_vtype; + let iface_tooltip; - if (me.iftype === 'bridge') { + if (me.iftype === 'bridge' || me.iftype === 'OVSBridge') { iface_vtype = 'BridgeName'; - } else if (me.iftype === 'bond') { + iface_tooltip = gettext('Commonly: vmbr[N] (e.g., vmbr0, vmbr1). Must start with a character, max 10 alphanumeric characters.'); + } else if (me.iftype === 'bond' || me.iftype === 'OVSBond') { iface_vtype = 'BondName'; + iface_tooltip = gettext('Format: bond[N] (e.g., bond0, bond1)'); } else if (me.iftype === 'eth' && !me.isCreate) { iface_vtype = 'InterfaceName'; + iface_tooltip = gettext('Format: eth[N] (e.g., eth0, enp0s3, )'); } else if (me.iftype === 'vlan') { iface_vtype = 'VlanName'; - } else if (me.iftype === 'OVSBridge') { - iface_vtype = 'BridgeName'; - } else if (me.iftype === 'OVSBond') { - iface_vtype = 'BondName'; - } else if (me.iftype === 'OVSIntPort') { - iface_vtype = 'InterfaceName'; - } else if (me.iftype === 'OVSPort') { + iface_tooltip = gettext('Format: [interface].[vlan-id] (e.g., eno1.50, bond1.30)'); + } else if (me.iftype === 'OVSIntPort' || me.iftype === 'OVSPort') { iface_vtype = 'InterfaceName'; + iface_tooltip = gettext('Alphanumeric string starting with a character.'); } else { console.log(me.iftype); throw 'unknown network device type specified'; @@ -332,7 +332,7 @@ Ext.define('Proxmox.node.NetworkEdit', { maxLength: iface_vtype === 'BridgeName' ? 10 : 15, autoEl: { tag: 'div', - 'data-qtip': gettext('For example, vmbr0.100, vmbr0, vlan0.100, vlan0'), + 'data-qtip': iface_tooltip, }, listeners: { change: function (f, value) { -- 2.47.3