From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 771DC1FF150 for ; Mon, 06 Jul 2026 11:43:11 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1F972214AD; Mon, 06 Jul 2026 11:43:02 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH storage 3/3] zfspool plugin: clone: fix linked clone of container subvol with refquota=none Date: Mon, 6 Jul 2026 11:40:34 +0200 Message-ID: <20260706094223.54701-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260706094223.54701-1-f.ebner@proxmox.com> References: <20260706094223.54701-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783330940886 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: EJSYHCIRBAM5XFDVDKNW37NQDH4I73LT X-Message-ID-Hash: EJSYHCIRBAM5XFDVDKNW37NQDH4I73LT X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ZFS does not accept the value 0 for the refquota property, but requires 'none' to be used instead. The refquota is queried with '-p' to get the exact parsable value and there, 'none' is returned as 0. It needs to be converted back to 'none' for the 'zfs clone' invocation. Fixes: 851658c ("Change zfs path when link clone are used") Signed-off-by: Fiona Ebner --- src/PVE/Storage/ZFSPoolPlugin.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/Storage/ZFSPoolPlugin.pm b/src/PVE/Storage/ZFSPoolPlugin.pm index c463112..418a65b 100644 --- a/src/PVE/Storage/ZFSPoolPlugin.pm +++ b/src/PVE/Storage/ZFSPoolPlugin.pm @@ -726,6 +726,7 @@ sub clone_image { if ($format eq 'subvol') { my $refquota = $class->zfs_get_properties($scfg, 'refquota', "$scfg->{pool}/$basename"); + $refquota = 'none' if $refquota == 0; # zfs does not accept 0 for refquota property $class->zfs_request( $scfg, undef, -- 2.47.3