From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id C447E1FF150 for ; Mon, 06 Jul 2026 11:43:00 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 934EF2144D; Mon, 06 Jul 2026 11:43:00 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH storage 2/3] zfspool plugin: clone image: use zfs_get_properties() helper Date: Mon, 6 Jul 2026 11:40:33 +0200 Message-ID: <20260706094223.54701-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260706094223.54701-1-f.ebner@proxmox.com> References: <20260706094223.54701-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783330940826 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: P34U733BUT74ZPRUJ4EK46AKVJV3GJ6G X-Message-ID-Hash: P34U733BUT74ZPRUJ4EK46AKVJV3GJ6G X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: No functional change intended. Signed-off-by: Fiona Ebner --- src/PVE/Storage/ZFSPoolPlugin.pm | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/PVE/Storage/ZFSPoolPlugin.pm b/src/PVE/Storage/ZFSPoolPlugin.pm index 0531a5d..c463112 100644 --- a/src/PVE/Storage/ZFSPoolPlugin.pm +++ b/src/PVE/Storage/ZFSPoolPlugin.pm @@ -725,10 +725,7 @@ sub clone_image { my $name = $class->find_free_diskname($storeid, $scfg, $vmid, $format); if ($format eq 'subvol') { - my $size = $class->zfs_request( - $scfg, undef, 'list', '-Hp', '-o', 'refquota', "$scfg->{pool}/$basename", - ); - chomp($size); + my $refquota = $class->zfs_get_properties($scfg, 'refquota', "$scfg->{pool}/$basename"); $class->zfs_request( $scfg, undef, @@ -736,7 +733,7 @@ sub clone_image { "$scfg->{pool}/$basename\@$snap", "$scfg->{pool}/$name", '-o', - "refquota=$size", + "refquota=$refquota", ); } else { $class->zfs_request( -- 2.47.3