From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 99D241FF142 for ; Fri, 03 Jul 2026 17:31:04 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5A8282144A; Fri, 03 Jul 2026 17:30:58 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH v2 manager 09/13] pvestatd: apply the cluster-wide multipath config on each node Date: Fri, 3 Jul 2026 14:46:09 +0200 Message-ID: <20260703124707.1172980-11-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260703124707.1172980-2-t.lamprecht@proxmox.com> References: <20260703124707.1172980-2-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783092616230 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: V42YCZUV2L3YM7OFOZ34IDTLPNBV6BS7 X-Message-ID-Hash: V42YCZUV2L3YM7OFOZ34IDTLPNBV6BS7 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Write out the cluster-wide multipath.cfg on each node once per status loop: build the local multipathd drop-ins and reload multipathd when they change. The work is a cheap no-op unless multipath is in use, and the logic is kept out of pvestatd itself, so this is just a thin trigger. Signed-off-by: Thomas Lamprecht --- Changes in v2: - broadcast whether this node could apply the config - use PVE::Multipath explicitly instead of relying on the generator pulling it in PVE/Service/pvestatd.pm | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm index 34f9da71f..1bdd1db65 100755 --- a/PVE/Service/pvestatd.pm +++ b/PVE/Service/pvestatd.pm @@ -20,6 +20,8 @@ use PVE::RS::SDN::Fabrics; use PVE::NodeConfig; use PVE::Cluster qw(cfs_read_file); use PVE::Storage; +use PVE::Multipath; +use PVE::Multipath::Generator; use PVE::QemuServer; use PVE::QemuServer::Monitor; use PVE::LXC; @@ -848,6 +850,16 @@ sub update_status { $err = $@; syslog('err', "storage status update error: $err") if $err; + # apply the cluster-wide multipath config on this node; a cheap no-op unless multipath is in + # use, and the logic is kept out of pvestatd so this stays a thin trigger. Broadcast a failed + # apply so a node drifting from the configured state shows up in the datacenter view. + my $apply_err = eval { PVE::Multipath::Generator::sync(); }; + $apply_err = $@ if $@; + syslog('err', "multipath config sync error: $apply_err") if $apply_err; + eval { PVE::Multipath::broadcast_apply_status($apply_err); }; + $err = $@; + syslog('err', "multipath apply-status broadcast error: $err") if $err; + eval { remove_stale_lxc_consoles(); }; $err = $@; syslog('err', "lxc console cleanup error: $err") if $err; -- 2.47.3