From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 5A10A1FF142 for ; Fri, 03 Jul 2026 13:56:19 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4952E21472; Fri, 03 Jul 2026 13:56:10 +0200 (CEST) From: Thomas Ellmenreich To: pve-devel@lists.proxmox.com Subject: [RFC cluster/manager 0/2] Configurable window titles for nodes Date: Fri, 3 Jul 2026 13:55:28 +0200 Message-ID: <20260703115530.106413-1-t.ellmenreich@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783079727992 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.400 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_ASCII_DIVIDERS 0.8 Email that uses ascii formatting dividers and possible spam tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SA4XED5M6A26MT7THMVU54N32DFQG43B X-Message-ID-Hash: SA4XED5M6A26MT7THMVU54N32DFQG43B X-MailFrom: t.ellmenreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Thomas Ellmenreich X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Configurable window titles for nodes ==================================== Currently the window title is fixed to the following string: $nodename - Proxmox Virtual Environment This has become problematic for users with multiple clusters, each containing the same node name. To help distinguish between tabs, it has been requested [1] that the window title be made configurable with the fqdn as an option. [1] https://bugzilla.proxmox.com/show_bug.cgi?id=5475 Current implementation ---------------------- After considering the different options, I have deemed a server side implementation, through the datacenter.cfg, to be the better option. Specifically because of its durability across sessions and because it automatically configures the title for all users and all nodes across the cluster. The config file stores an enum string that will then be converted to a window title and inserted in the index.html.tpl file on every request. The current enum options are: - default - Displays the default '$nodename - Proxmox Virtual Environment' string if the config enum is not present - 'nodeandcluster' - Displays the nodename and then the clustername in the following style: '$nodename - $clustername' - 'fqdn' - Displays the current fqdn as returned by `PVE::Tools::get_fqdn()` Implementation options ---------------------- The main question of this rfc is whether to implement this option as a client-side or server-side configuration. In my eyes, the pros and cons of each approach are the following. Storing config on clientside ---------------------------- Pros: - Compared to a change in the datacenter.cfg, a session config does not have a lasting impact on nodes. - Every user can set the config themselves independent of the choices of the admin. Cons: - Every user is forced to change it themselves, there is no way to change the window title for all users - The title has to be changed for every single Node, even for a single User there is no way to change all nodes to a specific window title schema. - Configuration is not durable, meaning that it has to be set again after each Localstorage clear. Storing config in datacenter.cfg -------------------------------- Pros: - The config is set once per cluster and will then be applied to every Node automatically. - Is persistent across sessions, and for all users, meaning it never has to be set again. Cons: - Since it is a change in the Datacenter config the change is more persistent - Users can not customize the window title themselves. - Only an Admin can change the configuration. Conclusion ---------- I would appreciate feedback on both the approach and the configuration options. Are there any reasons for one or the other that I may have overlooked? Are there any other types of window title that we and the community would appreciate? Additional note --------------- If proper cross-node user settings are implemented in the future, this topic could be revisited, as some of the disadvantages of having a user-defined configuration would disappear. pve-manager: Thomas Ellmenreich (1): fix #5475: configurable window title PVE/Service/pveproxy.pm | 21 +++++++++++++++++++++ www/index.html.tpl | 2 +- www/manager6/Utils.js | 11 +++++++++++ www/manager6/dc/OptionView.js | 6 ++++++ 4 files changed, 39 insertions(+), 1 deletion(-) pve-cluster: Thomas Ellmenreich (1): fix #5475: configurable window title src/PVE/DataCenterConfig.pm | 7 +++++++ 1 file changed, 7 insertions(+) Summary over all repositories: 5 files changed, 46 insertions(+), 1 deletions(-) -- Generated by murpp 0.12.0